From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-clk <linux-clk@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Keguang Zhang" <keguang.zhang@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element
Date: Tue, 1 Feb 2022 20:43:35 +0100 [thread overview]
Message-ID: <YfmNZ882rcI7c8Kq@latitude> (raw)
In-Reply-To: <CAAdtpL5xVjiKSFVcdFiMQHrki2bDSbDppP65QDC5ybBp3u-kMw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]
On Tue, Feb 01, 2022 at 02:57:03PM +0100, Philippe Mathieu-Daudé wrote:
> On Mon, Jan 31, 2022 at 12:48 PM Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> >
> > In order that the end of a clk_div_table can be detected, it must be
> > terminated with a sentinel element (.div = 0).
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > ---
> > drivers/clk/loongson1/clk-loongson1c.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c
> > index 703f87622cf5f..6b29ae9ede3e5 100644
> > --- a/drivers/clk/loongson1/clk-loongson1c.c
> > +++ b/drivers/clk/loongson1/clk-loongson1c.c
> > @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = {
> > [1] = { .val = 1, .div = 4 },
> > [2] = { .val = 2, .div = 3 },
> > [3] = { .val = 3, .div = 3 },
> > + [4] = { .val = 0, .div = 0 },
>
> Easier to review when self-explicit:
>
> [4] = { /* sentinel */ }
>
> Preferably updated:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> And eventually:
> Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support")
All good suggestions, I'll incorporate them into v2.
Thanks,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-02-01 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220128230922.2047140-1-j.neuschaefer@gmx.net>
2022-01-28 23:09 ` [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element Jonathan Neuschäfer
2022-02-01 13:57 ` Philippe Mathieu-Daudé
2022-02-01 19:43 ` Jonathan Neuschäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfmNZ882rcI7c8Kq@latitude \
--to=j.neuschaefer@gmx.net \
--cc=f4bug@amsat.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).