From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org,
Vineet Gupta <vgupta@synopsys.com>,
linux-snps-arc@lists.infradead.org,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Guo Ren <guoren@kernel.org>,
linux-csky@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, Nick Hu <nickhu@andestech.com>,
Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>,
libc-alpha@sourceware.org, Dave Martin <Dave.Martin@arm.com>,
Martin Sebor <msebor@redhat.com>
Subject: Re: [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper
Date: Sun, 17 Jan 2021 21:34:16 +0100 [thread overview]
Message-ID: <a2418a0e-9b21-4a02-dc0b-98936c0887fa@gmail.com> (raw)
In-Reply-To: <20210116145632.7636-1-alx.manpages@gmail.com>
Hi Alex,
On 1/16/21 3:56 PM, Alejandro Colomar wrote:
> Glibc uses 'void *' instead of 'char *'.
> And the prototype is declared in <sys/cacheflush.h>.
>
> ......
>
> $ syscall='cacheflush';
> $ ret='int';
> $ find glibc/ -type f -name '*.h' \
> |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;";
> glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27:
> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
> glibc/sysdeps/unix/sysv/linux/mips/sys/cachectl.h:35:
> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
> glibc/sysdeps/unix/sysv/linux/arc/sys/cachectl.h:30:
> extern int cacheflush (void *__addr, int __nbytes, int __op) __THROW;
> glibc/sysdeps/unix/sysv/linux/csky/sys/cachectl.h:30:
> extern int cacheflush (void *__addr, const int __nbytes,
> const int __op) __THROW;
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Thanks. Patch applied.
Cheers,
Michael
> ---
> man2/cacheflush.2 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/man2/cacheflush.2 b/man2/cacheflush.2
> index 2cf624f3a..0496879ca 100644
> --- a/man2/cacheflush.2
> +++ b/man2/cacheflush.2
> @@ -27,9 +27,9 @@
> cacheflush \- flush contents of instruction and/or data cache
> .SH SYNOPSIS
> .nf
> -.B #include <asm/cachectl.h>
> +.B #inlcude <sys/cacheflush.h>
> .PP
> -.BI "int cacheflush(char *" addr ", int "nbytes ", int "cache );
> +.BI "int cacheflush(void *" addr ", int "nbytes ", int "cache );
> .fi
> .PP
> .IR Note :
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2021-01-17 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 14:56 [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper Alejandro Colomar
2021-01-17 20:34 ` Michael Kerrisk (man-pages) [this message]
2021-01-17 20:43 ` Alejandro Colomar (man-pages)
2021-01-17 20:55 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2418a0e-9b21-4a02-dc0b-98936c0887fa@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=Dave.Martin@arm.com \
--cc=alx.manpages@gmail.com \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=msebor@redhat.com \
--cc=nickhu@andestech.com \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@synopsys.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).