linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
@ 2020-02-05  4:00 Tiezhu Yang
  2020-02-05  4:26 ` Tiezhu Yang
  0 siblings, 1 reply; 8+ messages in thread
From: Tiezhu Yang @ 2020-02-05  4:00 UTC (permalink / raw)
  To: Paul Burton, Ralf Baechle, Jean Delvare, Jean Delvare
  Cc: Yinglu Yang, Jiaxun Yang, Huacai Chen, Xuefeng Li, linux-mips,
	linux-kernel

Use SMBIOS_ENTRY_POINT_SCAN_START instead of 0xF0000, because other
archtecture maybe use a special start address such as 0xFFFE000 for
Loongson platform.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
---

v3:
  - split the v2 patch into two patches
  - make MIPS DMI config depend on MACH_LOONGSON64

v2:
  - add SMBIOS_ENTRY_POINT_SCAN_START suggested by Jean
  - refine definitions and Kconfig by Jiaxun

 drivers/firmware/dmi_scan.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 2045566..f59163c 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -11,6 +11,10 @@
 #include <asm/dmi.h>
 #include <asm/unaligned.h>
 
+#ifndef SMBIOS_ENTRY_POINT_SCAN_START
+#define SMBIOS_ENTRY_POINT_SCAN_START 0xF0000
+#endif
+
 struct kobject *dmi_kobj;
 EXPORT_SYMBOL_GPL(dmi_kobj);
 
@@ -663,7 +667,7 @@ static void __init dmi_scan_machine(void)
 			return;
 		}
 	} else if (IS_ENABLED(CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK)) {
-		p = dmi_early_remap(0xF0000, 0x10000);
+		p = dmi_early_remap(SMBIOS_ENTRY_POINT_SCAN_START, 0x10000);
 		if (p == NULL)
 			goto error;
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
  2020-02-05  4:00 [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START Tiezhu Yang
@ 2020-02-05  4:26 ` Tiezhu Yang
  0 siblings, 0 replies; 8+ messages in thread
From: Tiezhu Yang @ 2020-02-05  4:26 UTC (permalink / raw)
  To: Paul Burton, Ralf Baechle, Jean Delvare, Jean Delvare
  Cc: Yinglu Yang, Jiaxun Yang, Huacai Chen, Xuefeng Li, linux-mips,
	linux-kernel

On 2/5/20 12:00 PM, Tiezhu Yang wrote:
> Use SMBIOS_ENTRY_POINT_SCAN_START instead of 0xF0000, because other
> archtecture maybe use a special start address such as 0xFFFE000 for
> Loongson platform.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
> ---
>
> v3:
>    - split the v2 patch into two patches
>    - make MIPS DMI config depend on MACH_LOONGSON64
>
> v2:
>    - add SMBIOS_ENTRY_POINT_SCAN_START suggested by Jean
>    - refine definitions and Kconfig by Jiaxun
>
>   drivers/firmware/dmi_scan.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index 2045566..f59163c 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -11,6 +11,10 @@
>   #include <asm/dmi.h>
>   #include <asm/unaligned.h>
>   
> +#ifndef SMBIOS_ENTRY_POINT_SCAN_START
> +#define SMBIOS_ENTRY_POINT_SCAN_START 0xF0000
> +#endif
> +
>   struct kobject *dmi_kobj;
>   EXPORT_SYMBOL_GPL(dmi_kobj);
>   
> @@ -663,7 +667,7 @@ static void __init dmi_scan_machine(void)
>   			return;
>   		}
>   	} else if (IS_ENABLED(CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK)) {
> -		p = dmi_early_remap(0xF0000, 0x10000);
> +		p = dmi_early_remap(SMBIOS_ENTRY_POINT_SCAN_START, 0x10000);
>   		if (p == NULL)
>   			goto error;
>   

Sorry, there appears to be some issues when git send-email,

please ignore the repeated patch:

[PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START.

the correct send time of series patch is 2020-02-05 4:08 UTC, the link is

https://lore.kernel.org/patchwork/patch/1189713/

https://lore.kernel.org/patchwork/patch/1189714/


Thanks,


Tiezhu Yang


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
  2020-03-27  1:21     ` Tiezhu Yang
@ 2020-03-27  9:21       ` Jean Delvare
  0 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2020-03-27  9:21 UTC (permalink / raw)
  To: Tiezhu Yang
  Cc: jiaxun.yang, chenhc, linux-kernel, linux-mips, lixuefeng,
	paulburton, ralf, Thomas Bogendoerfer

On Fri, 27 Mar 2020 09:21:17 +0800, Tiezhu Yang wrote:
> On 03/26/2020 10:07 PM, Jean Delvare wrote:
> > Hi Tiezhu,
> >
> > On Thu, 20 Feb 2020 10:43:56 +0800, Tiezhu Yang wrote:  
> >> Since this patch is independent and it has no any negative influence,
> >> could you apply it to your DMI tree first?  
> > I've just queued your patch for kernel 5.6. Thanks for your
> > contribution and sorry for the delay.
> >  
> 
> Hi Jean,
> 
> Thank you very much, it has been merged into
> mips-next and linux-next tree by Thomas about
> three days ago, so you can drop it in your tree.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=3da27a4eb8c214d692e024473415fe7d2e88e7d7
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3da27a4eb8c214d692e024473415fe7d2e88e7d7

OK, I removed it from my dmi tree to avoid conflicts.

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
  2020-03-26 14:07   ` Jean Delvare
@ 2020-03-27  1:21     ` Tiezhu Yang
  2020-03-27  9:21       ` Jean Delvare
  0 siblings, 1 reply; 8+ messages in thread
From: Tiezhu Yang @ 2020-03-27  1:21 UTC (permalink / raw)
  To: Jean Delvare
  Cc: jiaxun.yang, chenhc, linux-kernel, linux-mips, lixuefeng,
	paulburton, ralf, Thomas Bogendoerfer

On 03/26/2020 10:07 PM, Jean Delvare wrote:
> Hi Tiezhu,
>
> On Thu, 20 Feb 2020 10:43:56 +0800, Tiezhu Yang wrote:
>> Since this patch is independent and it has no any negative influence,
>> could you apply it to your DMI tree first?
> I've just queued your patch for kernel 5.6. Thanks for your
> contribution and sorry for the delay.
>

Hi Jean,

Thank you very much, it has been merged into
mips-next and linux-next tree by Thomas about
three days ago, so you can drop it in your tree.

https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=3da27a4eb8c214d692e024473415fe7d2e88e7d7
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3da27a4eb8c214d692e024473415fe7d2e88e7d7

Thanks,

Tiezhu Yang


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
  2020-02-20  2:43 ` Tiezhu Yang
@ 2020-03-26 14:07   ` Jean Delvare
  2020-03-27  1:21     ` Tiezhu Yang
  0 siblings, 1 reply; 8+ messages in thread
From: Jean Delvare @ 2020-03-26 14:07 UTC (permalink / raw)
  To: Tiezhu Yang
  Cc: jiaxun.yang, chenhc, linux-kernel, linux-mips, lixuefeng,
	paulburton, ralf

Hi Tiezhu,

On Thu, 20 Feb 2020 10:43:56 +0800, Tiezhu Yang wrote:
> Since this patch is independent and it has no any negative influence,
> could you apply it to your DMI tree first?

I've just queued your patch for kernel 5.6. Thanks for your
contribution and sorry for the delay.

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
  2020-02-05  4:08 Tiezhu Yang
@ 2020-02-20  2:43 ` Tiezhu Yang
  2020-03-26 14:07   ` Jean Delvare
  0 siblings, 1 reply; 8+ messages in thread
From: Tiezhu Yang @ 2020-02-20  2:43 UTC (permalink / raw)
  To: jdelvare, jdelvare
  Cc: jiaxun.yang, chenhc, linux-kernel, linux-mips, lixuefeng,
	paulburton, ralf

Hi Jean,

Since this patch is independent and it has no any negative influence,
could you apply it to your DMI tree first?

Thanks,

Tiezhu Yang


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
@ 2020-02-05  4:08 Tiezhu Yang
  2020-02-20  2:43 ` Tiezhu Yang
  0 siblings, 1 reply; 8+ messages in thread
From: Tiezhu Yang @ 2020-02-05  4:08 UTC (permalink / raw)
  To: Paul Burton, Ralf Baechle, Jean Delvare, Jean Delvare
  Cc: Huacai Chen, Xuefeng Li, linux-mips, linux-kernel

Use SMBIOS_ENTRY_POINT_SCAN_START instead of 0xF0000, because other
archtecture maybe use a special start address such as 0xFFFE000 for
Loongson platform.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
---

v3:
  - split the v2 patch into two patches
  - make MIPS DMI config depend on MACH_LOONGSON64

v2:
  - add SMBIOS_ENTRY_POINT_SCAN_START suggested by Jean
  - refine definitions and Kconfig by Jiaxun

 drivers/firmware/dmi_scan.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 2045566..f59163c 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -11,6 +11,10 @@
 #include <asm/dmi.h>
 #include <asm/unaligned.h>
 
+#ifndef SMBIOS_ENTRY_POINT_SCAN_START
+#define SMBIOS_ENTRY_POINT_SCAN_START 0xF0000
+#endif
+
 struct kobject *dmi_kobj;
 EXPORT_SYMBOL_GPL(dmi_kobj);
 
@@ -663,7 +667,7 @@ static void __init dmi_scan_machine(void)
 			return;
 		}
 	} else if (IS_ENABLED(CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK)) {
-		p = dmi_early_remap(0xF0000, 0x10000);
+		p = dmi_early_remap(SMBIOS_ENTRY_POINT_SCAN_START, 0x10000);
 		if (p == NULL)
 			goto error;
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
@ 2020-02-05  4:05 Tiezhu Yang
  0 siblings, 0 replies; 8+ messages in thread
From: Tiezhu Yang @ 2020-02-05  4:05 UTC (permalink / raw)
  To: Paul Burton, Ralf Baechle, Jean Delvare, Jean Delvare
  Cc: Huacai Chen, Xuefeng Li, linux-mips, linux-kernel

Use SMBIOS_ENTRY_POINT_SCAN_START instead of 0xF0000, because other
archtecture maybe use a special start address such as 0xFFFE000 for
Loongson platform.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
---

v3:
  - split the v2 patch into two patches
  - make MIPS DMI config depend on MACH_LOONGSON64

v2:
  - add SMBIOS_ENTRY_POINT_SCAN_START suggested by Jean
  - refine definitions and Kconfig by Jiaxun

 drivers/firmware/dmi_scan.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 2045566..f59163c 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -11,6 +11,10 @@
 #include <asm/dmi.h>
 #include <asm/unaligned.h>
 
+#ifndef SMBIOS_ENTRY_POINT_SCAN_START
+#define SMBIOS_ENTRY_POINT_SCAN_START 0xF0000
+#endif
+
 struct kobject *dmi_kobj;
 EXPORT_SYMBOL_GPL(dmi_kobj);
 
@@ -663,7 +667,7 @@ static void __init dmi_scan_machine(void)
 			return;
 		}
 	} else if (IS_ENABLED(CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK)) {
-		p = dmi_early_remap(0xF0000, 0x10000);
+		p = dmi_early_remap(SMBIOS_ENTRY_POINT_SCAN_START, 0x10000);
 		if (p == NULL)
 			goto error;
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-27  9:21 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05  4:00 [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START Tiezhu Yang
2020-02-05  4:26 ` Tiezhu Yang
2020-02-05  4:05 Tiezhu Yang
2020-02-05  4:08 Tiezhu Yang
2020-02-20  2:43 ` Tiezhu Yang
2020-03-26 14:07   ` Jean Delvare
2020-03-27  1:21     ` Tiezhu Yang
2020-03-27  9:21       ` Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).