From: Joshua Kinard <kumba@gentoo.org>
To: Ralf Baechle <ralf@linux-mips.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Linux/MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: Add ifdefs to IP22/IP32's Platform files
Date: Sat, 28 Jan 2017 23:00:13 -0500 [thread overview]
Message-ID: <aefec5f3-1d00-99c1-3ee0-da972b7bd4ab@gentoo.org> (raw)
In-Reply-To: <b290b37d-b136-0766-44ce-a094b336779a@gentoo.org>
On 01/28/2017 22:38, Joshua Kinard wrote:
> From: Joshua Kinard <kumba@gentoo.org>
>
> Prevent IP22/IP32's Platform directives from mixing into builds of
> other MIPS platforms. During a recent IP27 build, erroneous R10K
> cache barrier instructions were being emitted before every load or
> store instruction. This was caused by IP27 accidentally picking up
> the -mr10k-cache-barrier option from arch/mips/sgi-ip32/Platform.
>
> By wrapping the directives in both IP22 and IP32's Platform file
> inside an 'ifdef' block, as is already done in IP27's Platform file,
> this prevents the R10K cache barriers from being emitted on platforms
> where they are not needed.
>
[snip]
Scrub this one. I'll send a fixed copy shortly. I diffed it from the
wrong branch on my local git, which includes testing for IP32 R10K/R12K.
--J
prev parent reply other threads:[~2017-01-29 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 3:38 [PATCH] MIPS: Add ifdefs to IP22/IP32's Platform files Joshua Kinard
2017-01-29 4:00 ` Joshua Kinard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aefec5f3-1d00-99c1-3ee0-da972b7bd4ab@gentoo.org \
--to=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).