From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C69C47404 for ; Wed, 9 Oct 2019 13:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EECE21835 for ; Wed, 9 Oct 2019 13:46:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731181AbfJINqZ (ORCPT ); Wed, 9 Oct 2019 09:46:25 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:36538 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731180AbfJINqY (ORCPT ); Wed, 9 Oct 2019 09:46:24 -0400 Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S23993463AbfJINqWU6nXj (ORCPT ); Wed, 9 Oct 2019 15:46:22 +0200 Date: Wed, 9 Oct 2019 14:46:22 +0100 (BST) From: "Maciej W. Rozycki" To: Paul Burton cc: "linux-mips@vger.kernel.org" , Paul Burton Subject: Re: [PATCH 1/4] MIPS: cmdline: Remove CONFIG_MIPS_CMDLINE_BUILTIN_EXTEND In-Reply-To: <20191007221951.1889661-1-paul.burton@mips.com> Message-ID: References: <20191007221951.1889661-1-paul.burton@mips.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, 7 Oct 2019, Paul Burton wrote: > CONFIG_MIPS_CMDLINE_BUILTIN_EXTEND is not selected by any of our > defconfigs, so remove it to simplify the messy command line logic in > arch_mem_init() a little. That sounds like a poor argument for a functional regression to me. I have the option enabled in several configs I have been using just to be able to temporarily override any built-in parameters with ones typed from the console monitor's prompt. Is it my mistake that I haven't put it in a defconfig? Maciej