From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA0FC34021 for ; Mon, 17 Feb 2020 13:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C1592072C for ; Mon, 17 Feb 2020 13:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726866AbgBQNi7 (ORCPT ); Mon, 17 Feb 2020 08:38:59 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:45118 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726779AbgBQNi7 (ORCPT ); Mon, 17 Feb 2020 08:38:59 -0500 Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S23990923AbgBQNizHwSiF (ORCPT ); Mon, 17 Feb 2020 14:38:55 +0100 Date: Mon, 17 Feb 2020 13:38:55 +0000 (GMT) From: "Maciej W. Rozycki" To: Paul Burton cc: "Victor Kamensky (kamensky)" , "linux-mips@vger.kernel.org" , Ralf Baechle , James Hogan , Vincenzo Frascino , "bruce.ashfield@gmail.com" , "richard.purdie@linuxfoundation.org" Subject: Re: [PATCH 1/2] mips: vdso: fix 'jalr t9' crash in vdso code In-Reply-To: <20200211170110.ewrndsh7zzx7ocqi@lantea.localdomain> Message-ID: References: <20200203233133.38613-1-kamensky@cisco.com> <20200203233133.38613-2-kamensky@cisco.com> <20200210191424.brqyxs5lq7eqounl@lantea.localdomain> <20200210193301.ella5mokkudw3qgs@lantea.localdomain> <20200210225229.4px5rljkici4mlrj@lantea.localdomain> <20200211170110.ewrndsh7zzx7ocqi@lantea.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, 11 Feb 2020, Paul Burton wrote: > > I believe my second patch: build time check for 'jalr t9' in code > > should still be useful, since it verifies that conversion to 'bal' driven > > by -mrelax-pic-calls does happen. > > > > Please let me know if you have any additional feedback before > > I post v2 set of patches. > > That sounds great, and nothing else springs to mind. I'll look out for > v2. BTW, while at it you might want to verify that the microMIPS variant does the right thing. As I recall there was an issue with the R_MICROMIPS_JALR reloc that I meant to fix, but didn't get to before I left MIPS. Maciej