Linux-MIPS Archive on
 help / color / Atom feed
From: "Maciej W. Rozycki" <>
To: Sergei Shtylyov <>
Cc: Thomas Bogendoerfer <>,,
Subject: Re: [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file
Date: Sat, 10 Oct 2020 13:11:18 +0100 (BST)
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, 10 Oct 2020, Sergei Shtylyov wrote:

> >   Umm, this has formatting issues with lines extending beyond column #80.
>    80 columns are no longer a line length limit -- 100 is, IIRC.

 I don't think anything has changed here:

"The preferred limit on the length of a single line is 80 columns.

"Statements longer than 80 columns should be broken into sensible chunks,
unless exceeding 80 columns significantly increases readability and does
not hide information."

-- from Documentation/process/coding-style.rst, "Breaking long lines and 

 And if it were to change anytime, then I think it would make sense for 
such a new rule to apply to new files only.  I would be strongly against 
it anyway, as the human's capability to parse lines has not changed when 
it comes to the quantity of characters easily processed at once: the angle 
spanned by eyes is hardwired.  For this reason the GNU toolchain projects 
keep the limit even lower, at 74 columns (after extensive discussions).


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 21:33 Thomas Bogendoerfer
2020-10-08 21:33 ` [PATCH v2 2/2] MIPS: cpu-probe: introduce exclusive R3k CPU probe Thomas Bogendoerfer
2020-10-12 10:30   ` Thomas Bogendoerfer
2020-10-10  0:30 ` [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file Maciej W. Rozycki
2020-10-10  8:56   ` Sergei Shtylyov
2020-10-10 12:11     ` Maciej W. Rozycki [this message]
2020-10-12 11:17       ` Sergei Shtylyov
2020-10-12 10:29   ` Thomas Bogendoerfer
2020-10-12 10:30 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-MIPS Archive on

Archives are clonable:
	git clone --mirror linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ \
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone