From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32BA4C433DF for ; Sat, 10 Oct 2020 23:07:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E47C2067C for ; Sat, 10 Oct 2020 23:07:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390481AbgJJW5Y (ORCPT ); Sat, 10 Oct 2020 18:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730825AbgJJTwD (ORCPT ); Sat, 10 Oct 2020 15:52:03 -0400 Received: from orcam.me.uk (unknown [IPv6:2001:4190:8020::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 065D8C0610D0; Sat, 10 Oct 2020 05:11:24 -0700 (PDT) Received: from bugs.linux-mips.org (eddie.linux-mips.org [IPv6:2a01:4f8:201:92aa::3]) by orcam.me.uk (Postfix) with ESMTPS id 683AD2BE086; Sat, 10 Oct 2020 13:11:22 +0100 (BST) Date: Sat, 10 Oct 2020 13:11:18 +0100 (BST) From: "Maciej W. Rozycki" To: Sergei Shtylyov cc: Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file In-Reply-To: <0d87a08c-3ae3-fc32-8e96-5692944b8289@gmail.com> Message-ID: References: <20201008213327.11603-1-tsbogend@alpha.franken.de> <0d87a08c-3ae3-fc32-8e96-5692944b8289@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, 10 Oct 2020, Sergei Shtylyov wrote: > > Umm, this has formatting issues with lines extending beyond column #80. > > 80 columns are no longer a line length limit -- 100 is, IIRC. I don't think anything has changed here: "The preferred limit on the length of a single line is 80 columns. "Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information." -- from Documentation/process/coding-style.rst, "Breaking long lines and strings". And if it were to change anytime, then I think it would make sense for such a new rule to apply to new files only. I would be strongly against it anyway, as the human's capability to parse lines has not changed when it comes to the quantity of characters easily processed at once: the angle spanned by eyes is hardwired. For this reason the GNU toolchain projects keep the limit even lower, at 74 columns (after extensive discussions). Maciej