From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Gkct=DV=vger.kernel.org=linux-mips-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 97835C43457
	for <linux-mips@archiver.kernel.org>; Wed, 14 Oct 2020 20:54:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 460F82224E
	for <linux-mips@archiver.kernel.org>; Wed, 14 Oct 2020 20:54:06 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729286AbgJNUyD (ORCPT <rfc822;linux-mips@archiver.kernel.org>);
        Wed, 14 Oct 2020 16:54:03 -0400
Received: from [157.25.102.26] ([157.25.102.26]:39198 "EHLO orcam.me.uk"
        rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726028AbgJNUyD (ORCPT <rfc822;linux-mips@vger.kernel.org>);
        Wed, 14 Oct 2020 16:54:03 -0400
X-Greylist: delayed 35030 seconds by postgrey-1.27 at vger.kernel.org; Wed, 14 Oct 2020 16:54:02 EDT
Received: from bugs.linux-mips.org (eddie.linux-mips.org [IPv6:2a01:4f8:201:92aa::3])
        by orcam.me.uk (Postfix) with ESMTPS id 6BC052BE086;
        Wed, 14 Oct 2020 21:53:59 +0100 (BST)
Date:   Wed, 14 Oct 2020 21:53:55 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@linux-mips.org>
To:     Serge Semin <fancer.lancer@gmail.com>
cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: DEC: Restore bootmem reservation for firmware
 working memory area
In-Reply-To: <20201014180114.fnz5ewt2tzkgxin4@mobilestation>
Message-ID: <alpine.LFD.2.21.2010142146110.866917@eddie.linux-mips.org>
References: <alpine.LFD.2.21.2010141123010.866917@eddie.linux-mips.org> <20201014180114.fnz5ewt2tzkgxin4@mobilestation>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-mips.vger.kernel.org>
X-Mailing-List: linux-mips@vger.kernel.org

Hello Serge,

> > @@ -146,6 +150,9 @@ void __init plat_mem_setup(void)
> >  
> >  	ioport_resource.start = ~0UL;
> >  	ioport_resource.end = 0UL;
> > +
> > +	/* Stay away from the firmware working memory area for now. */
> 
> > +	memblock_reserve(PHYS_OFFSET, __pa_symbol(&_text));
> 
> Shouldn't that be:
> +	memblock_reserve(PHYS_OFFSET, __pa_symbol(&_text) - PHYS_OFFSET);
> instead?

 Good point: unlike `free_init_pages' which uses start/end this function 
uses start/size as its arguments.  For DEC effectively it does not matter 
as PHYS_OFFSET is 0 anyway, but code has to be semantically correct.  
I'll post an update.

  Maciej