From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Hauke Mehrtens <hauke@hauke-m.de>, tsbogend@alpha.franken.de
Cc: linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, james.hartley@sondrel.com,
rahulbedarkar89@gmail.com, wigyori@uid0.hu
Subject: Re: [PATCH 2/3] MIPS: DTS: img: marduk: Add Cascoda CA8210 6LoWPAN
Date: Sun, 16 Aug 2020 12:14:15 +0300 [thread overview]
Message-ID: <b6267d62-af3b-4d29-51b0-3a61d0fd2679@gmail.com> (raw)
In-Reply-To: <20200815163514.11631-2-hauke@hauke-m.de>
Hello!
On 15.08.2020 19:35, Hauke Mehrtens wrote:
> Add Cascoda CA8210 6LoWPAN controller to device tree.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> arch/mips/boot/dts/img/pistachio_marduk.dts | 22 +++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts b/arch/mips/boot/dts/img/pistachio_marduk.dts
> index ea11a21b133b..633a41954cc0 100644
> --- a/arch/mips/boot/dts/img/pistachio_marduk.dts
> +++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
> @@ -75,6 +75,28 @@
> VDD-supply = <&internal_dac_supply>;
> };
>
> +&spfi0 {
> + status = "okay";
> + pinctrl-0 = <&spim0_pins>, <&spim0_cs0_alt_pin>, <&spim0_cs2_alt_pin>, <&spim0_cs3_alt_pin>, <&spim0_cs4_alt_pin>;
> + pinctrl-names = "default";
> +
> + cs-gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>, <&gpio0 2 GPIO_ACTIVE_HIGH>,
> + <&gpio1 12 GPIO_ACTIVE_HIGH>, <&gpio1 13 GPIO_ACTIVE_HIGH>;
> +
> + ca8210: ca8210@0 {
The device nodes are supposed to have the generic names...
> + status = "okay";
> + compatible = "cascoda,ca8210";
> + reg = <0>;
> + spi-max-frequency = <4000000>;
Only 4MHz?
> + spi-cpol;
> + reset-gpio = <&gpio0 12 GPIO_ACTIVE_HIGH>;
> + irq-gpio = <&gpio2 12 GPIO_ACTIVE_HIGH>;
> + extclock-enable;
> + extclock-freq = <16000000>;
> + extclock-gpio = <2>;
Hm, strange spec for a GPIO prop, shouldn't they all be alike?
> + };
> +};
> +
> &spfi1 {
> status = "okay";
>
MBR, Sergei
next prev parent reply other threads:[~2020-08-16 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 16:35 [PATCH 1/3] MIPS: DTS: img: marduk: Add SPI NAND flash Hauke Mehrtens
2020-08-15 16:35 ` [PATCH 2/3] MIPS: DTS: img: marduk: Add Cascoda CA8210 6LoWPAN Hauke Mehrtens
2020-08-16 9:14 ` Sergei Shtylyov [this message]
2020-08-16 10:59 ` Hauke Mehrtens
2020-08-16 17:06 ` Sergei Shtylyov
2020-08-15 16:35 ` [PATCH 3/3] MIPS: DTS: img: marduk: Add NXP SC16IS752IPW Hauke Mehrtens
2020-09-12 6:46 ` Zhou Yanjie
2020-09-03 20:40 ` [PATCH 1/3] MIPS: DTS: img: marduk: Add SPI NAND flash Rahul Bedarkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6267d62-af3b-4d29-51b0-3a61d0fd2679@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=james.hartley@sondrel.com \
--cc=linux-mips@vger.kernel.org \
--cc=rahulbedarkar89@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=wigyori@uid0.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).