From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DF9AC43331 for ; Wed, 25 Mar 2020 14:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F964207FC for ; Wed, 25 Mar 2020 14:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585145720; bh=4e5a3dthO0KUl7222D0WTEADwSKwuGJMGtQdIOGhnLA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=dMpp+L3Bg2Ya2DvFuf1m2dFS9SS3mgQ0IVR9tCqPmmi3uCj/DcIdlsAgAqhdEKa4B ehL6592U7ouvkIWzCBuJdZUyq8bE5tOzi8rt0AbRS+zv234uAu1a4hmnRA9tbgre36 kRNnkLmzgIhNvXHLgtcno1AeWFLV9GBNzY1AV6HE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbgCYOPT (ORCPT ); Wed, 25 Mar 2020 10:15:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:41122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727422AbgCYOPT (ORCPT ); Wed, 25 Mar 2020 10:15:19 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A89DA20658; Wed, 25 Mar 2020 14:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585145718; bh=4e5a3dthO0KUl7222D0WTEADwSKwuGJMGtQdIOGhnLA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KTJeidKgfSVy1x+XACNkhs0RALfLf4mqWrAgZoxIEpBs15MGrOlsymhj5+V884fsl jWXJ4syWFJ/e8tvYajfc6Io+0fsOX28fH4KTuG6Ecb4QvBoH2hGd9WnVt2jpaDf3mA Kz6mglsepSuQOfpuM2G5LPzqKOkVXnmrzPk6gF7A= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jH6oP-00FasG-0L; Wed, 25 Mar 2020 14:15:17 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 25 Mar 2020 14:15:16 +0000 From: Marc Zyngier To: Jiaxun Yang Cc: Thomas Bogendoerfer , linux-mips@vger.kernel.org, Huacai Chen , Thomas Gleixner , Jason Cooper , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Andy Shevchenko , Allison Randal , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v8 06/11] irqchip: mips-cpu: Convert to simple domain In-Reply-To: <4BB367D3-B8AD-47B6-ACC2-30752137BC1B@flygoat.com> References: <20200325035537.156911-1-jiaxun.yang@flygoat.com> <20200325035537.156911-7-jiaxun.yang@flygoat.com> <20200325123742.GA9911@alpha.franken.de> <5eb9ce9ea665ee32da40779f00fc9b37@kernel.org> <4BB367D3-B8AD-47B6-ACC2-30752137BC1B@flygoat.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jiaxun.yang@flygoat.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, chenhc@lemote.com, tglx@linutronix.de, jason@lakedaemon.net, robh+dt@kernel.org, mark.rutland@arm.com, mchehab+samsung@kernel.org, davem@davemloft.net, gregkh@linuxfoundation.org, Jonathan.Cameron@huawei.com, andriy.shevchenko@linux.intel.com, allison@lohutok.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 2020-03-25 13:59, Jiaxun Yang wrote: [...] >>> So probably we can use legacy domain when MIPS IRQ BASE is in the >>> range of legacy IRQ >>> and switch to simple domain when it's not in that range? >> >> No, see below. >> >>> Here in Loongson systems IRQ 0-15 is occupied by I8259 so I did this >>> hack. >> >> Well, if you have to consider which Linux IRQ gets assigned, >> then your platform is definitely not ready for non-legacy >> irqdomains. Just stick to legacy for now until you have removed >> all the code that knows the hwirq mapping. > > Thanks. > > So I have to allocate irq_desc here in driver manually? No, you are probably better off just dropping this patch, as MIPS doesn't seem to be ready for a wholesale switch to virtual interrupts. M. -- Jazz is not dead. It just smells funny...