Re: [PATCH v2 15/21] dt-bindings: pinctrl: {mediatek,ralink}: fix formatting

From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Rob Herring <robh@kernel.org>
Cc: "Sean Wang" <sean.wang@mediatek.com>,
	linux-arm-kernel@lists.infradead.org,
	"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
	"Bernhard Rosenkränzer" <bero@baylibre.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Hui Liu" <hui.liu@mediatek.com>,
	"Landen Chao" <Landen.Chao@mediatek.com>,
	linux-kernel@vger.kernel.org,
	"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
	"Del Regno" <angelogioacchino.delregno@collabora.com>,
	erkin.bozoglu@xeront.com, linux-gpio@vger.kernel.org,
	"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
	"Daniel Santos" <daniel.santos@pobox.com>,
	"Frank Wunderlich" <frank-w@public-files.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Andy Teng" <andy.teng@mediatek.com>,
	"William Dean" <williamsukatube@gmail.com>,
	devicetree@vger.kernel.org,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Sean Wang" <sean.wang@kernel.org>,
	linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
	"DENG Qingfang" <dqfext@gmail.com>
Subject: Re: [PATCH v2 15/21] dt-bindings: pinctrl: {mediatek,ralink}: fix formatting
Date: Tue, 14 Mar 2023 18:38:33 +0300	[thread overview]
Message-ID: <c64d9f88-75ca-3a6c-b5c2-6e4b1a161d5f@arinc9.com> (raw)
In-Reply-To: <167880254685.25972.15349420182231511267.robh@kernel.org>

On 14.03.2023 17:10, Rob Herring wrote:
> 
> On Mon, 13 Mar 2023 23:59:15 +0300, arinc9.unal@gmail.com wrote:
>> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>>
>> Change the style of description properties to plain style where there's no
>> need to preserve the line endings, and vice versa.
>>
>> Fit the schemas to 80 columns for each line.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>   .../pinctrl/mediatek,mt65xx-pinctrl.yaml      | 22 +++---
>>   .../pinctrl/mediatek,mt6779-pinctrl.yaml      | 33 +++++----
>>   .../pinctrl/mediatek,mt6795-pinctrl.yaml      | 33 +++++----
>>   .../pinctrl/mediatek,mt7620-pinctrl.yaml      |  2 +-
>>   .../pinctrl/mediatek,mt7621-pinctrl.yaml      |  2 +-
>>   .../pinctrl/mediatek,mt7622-pinctrl.yaml      | 26 +++----
>>   .../pinctrl/mediatek,mt7981-pinctrl.yaml      | 33 +++++----
>>   .../pinctrl/mediatek,mt7986-pinctrl.yaml      | 68 ++++++++---------
>>   .../pinctrl/mediatek,mt8183-pinctrl.yaml      | 26 ++++---
>>   .../pinctrl/mediatek,mt8186-pinctrl.yaml      | 47 ++++++------
>>   .../pinctrl/mediatek,mt8188-pinctrl.yaml      | 74 ++++++++++---------
>>   .../pinctrl/mediatek,mt8192-pinctrl.yaml      | 47 ++++++------
>>   .../pinctrl/mediatek,mt8195-pinctrl.yaml      | 41 +++++-----
>>   .../pinctrl/mediatek,mt8365-pinctrl.yaml      | 28 +++----
>>   .../pinctrl/ralink,rt2880-pinctrl.yaml        |  2 +-
>>   .../pinctrl/ralink,rt305x-pinctrl.yaml        |  2 +-
>>   .../pinctrl/ralink,rt3883-pinctrl.yaml        |  2 +-
>>   17 files changed, 254 insertions(+), 234 deletions(-)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:103:16: [warning] wrong indentation: expected 14 but found 15 (indentation)
> ./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:113:16: [warning] wrong indentation: expected 14 but found 15 (indentation)
> 
> dtschema/dtc warnings/errors:
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313205921.35342-16-arinc.unal@arinc9.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

I do see the warning. Looks like the wrong indentation was there before 
my patch series. I'll address that as well on this patch on v3.

Will you review the rest of v2?

Arınç