From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mark Brown <broonie@kernel.org>,
Steven Price <Steven.Price@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Kees Cook <keescook@chromium.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Matthew Wilcox <willy@infradead.org>,
Sri Krishna chowdary <schowdary@nvidia.com>,
Dave Hansen <dave.hansen@intel.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Vineet Gupta <vgupta@synopsys.com>,
James Hogan <jhogan@kernel.org>,
Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V12] mm/debug: Add tests validating architecture page table helpers
Date: Sun, 2 Feb 2020 09:31:18 +0100 [thread overview]
Message-ID: <e1e046d7-bf1d-eaec-1d0b-fe056b83b84c@c-s.fr> (raw)
In-Reply-To: <ad5ad414-3524-2efa-df16-1ee357e6e2e4@arm.com>
Le 02/02/2020 à 08:18, Anshuman Khandual a écrit :
> On 01/30/2020 07:43 PM, Christophe Leroy wrote:
>>
>>
>> Le 30/01/2020 à 14:04, Anshuman Khandual a écrit :
>>>
>>> On 01/28/2020 10:35 PM, Christophe Leroy wrote:
>>
>>>
>>>> I think we could make it standalone and 'default y if DEBUG_VM' instead.
>>>
>>> Which will yield the same result like before but in a different way. But
>>> yes, this test could go about either way but unless there is a good enough
>>> reason why change the current one.
>>
>> I think if we want people to really use it on other architectures it must be possible to activate it without having to modify Kconfig. Otherwise people won't even know the test exists and the architecture fails the test.
>>
>> The purpose of a test suite is to detect bugs. If you can't run the test until you have fixed the bugs, I guess nobody will ever detect the bugs and they will never be fixed.
>>
>> So I think:
>> - the test should be 'default y' when ARCH_HAS_DEBUG_VM_PGTABLE is selected
>> - the test should be 'default n' when ARCH_HAS_DEBUG_VM_PGTABLE is not selected, and it should be user selectable if EXPERT is selected.
>>
>> Something like:
>>
>> config DEBUG_VM_PGTABLE
>> bool "Debug arch page table for semantics compliance" if ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT
>> depends on MMU
>
> (ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT) be moved along side MMU on the same line ?
Yes could also go along side MMU, or could be a depend by itself:
depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT
>
>> default 'n' if !ARCH_HAS_DEBUG_VM_PGTABLE
>> default 'y' if DEBUG_VM
>
> This looks good, at least until we get all platforms enabled. Will do all these
> changes along with s390 enablement and re-spin.
Christophe
next prev parent reply other threads:[~2020-02-02 8:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 1:27 [PATCH V12] mm/debug: Add tests validating architecture page table helpers Anshuman Khandual
2020-01-28 2:11 ` Qian Cai
2020-01-28 3:06 ` Anshuman Khandual
2020-01-28 3:33 ` Qian Cai
2020-01-28 4:57 ` Anshuman Khandual
2020-01-28 5:48 ` Qian Cai
2020-01-28 6:17 ` Christophe Leroy
2020-01-28 6:36 ` Qian Cai
2020-01-28 7:03 ` Anshuman Khandual
2020-01-28 7:07 ` Qian Cai
2020-01-28 6:13 ` Christophe Leroy
2020-01-28 7:12 ` Qian Cai
2020-01-28 11:58 ` Mark Brown
2020-01-28 12:09 ` Mike Rapoport
2020-01-29 22:20 ` Gerald Schaefer
2020-01-30 7:27 ` Mike Rapoport
2020-01-30 13:32 ` Anshuman Khandual
2020-01-28 17:47 ` Catalin Marinas
2020-01-28 19:07 ` Qian Cai
2020-01-29 10:36 ` Catalin Marinas
2020-01-29 11:09 ` Qian Cai
2020-01-28 17:05 ` Christophe Leroy
2020-01-30 13:04 ` Anshuman Khandual
2020-01-30 14:13 ` Christophe Leroy
2020-02-02 7:18 ` Anshuman Khandual
2020-02-02 8:31 ` Christophe Leroy [this message]
2020-02-02 11:26 ` Qian Cai
2020-02-03 15:14 ` Christophe Leroy
2020-02-03 15:48 ` Qian Cai
2020-02-02 8:26 ` Anshuman Khandual
2020-01-29 22:20 ` Gerald Schaefer
2020-01-30 13:11 ` Anshuman Khandual
2020-01-30 15:06 ` Anshuman Khandual
2020-02-10 15:37 ` Catalin Marinas
2020-02-12 9:42 ` Anshuman Khandual
2020-02-12 17:55 ` Gerald Schaefer
2020-02-13 2:15 ` Anshuman Khandual
2020-01-28 12:30 Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1e046d7-bf1d-eaec-1d0b-fe056b83b84c@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=Steven.Price@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=davem@davemloft.net \
--cc=gerald.schaefer@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jhogan@kernel.org \
--cc=keescook@chromium.org \
--cc=kirill@shutemov.name \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=schowdary@nvidia.com \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=vgupta@synopsys.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).