From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 07 Apr 2017 15:57:50 +0200 (CEST) Received: from outils.crapouillou.net ([89.234.176.41]:58028 "EHLO outils.crapouillou.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993612AbdDGN5mtNYfJ (ORCPT ); Fri, 7 Apr 2017 15:57:42 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 07 Apr 2017 15:57:11 +0200 From: Paul Cercueil To: Linus Walleij Cc: Alexandre Courbot , Rob Herring , Mark Rutland , Ralf Baechle , Boris Brezillon , Thierry Reding , Bartlomiej Zolnierkiewicz , Maarten ter Huurne , Lars-Peter Clausen , Paul Burton , James Hogan , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux MIPS , linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v4 06/14] MIPS: jz4740: DTS: Add nodes for ingenic pinctrl and gpio drivers In-Reply-To: References: <20170125185207.23902-2-paul@crapouillou.net> <20170402204244.14216-1-paul@crapouillou.net> <20170402204244.14216-7-paul@crapouillou.net> Message-ID: X-Sender: paul@crapouillou.net Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 57620 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul@crapouillou.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Le 2017-04-07 11:44, Linus Walleij a écrit : > On Sun, Apr 2, 2017 at 10:42 PM, Paul Cercueil > wrote: > >> For a description of the pinctrl devicetree node, please read >> Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.txt >> >> For a description of the gpio devicetree nodes, please read >> Documentation/devicetree/bindings/gpio/ingenic,gpio.txt >> >> Signed-off-by: Paul Cercueil >> --- >> arch/mips/boot/dts/ingenic/jz4740.dtsi | 61 >> ++++++++++++++++++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> >> v2: Changed the devicetree bindings to match the new driver >> v3: No changes >> v4: Update the bindings for the v4 version of the drivers > (...) > >> + pinctrl: ingenic-pinctrl@10010000 { >> + compatible = "ingenic,jz4740-pinctrl"; >> + reg = <0x10010000 0x400>; >> + >> + gpa: gpio-controller@0 { >> + compatible = "ingenic,gpio-bank-a", >> "ingenic,jz4740-gpio"; > > As Sergei and Rob notes, the bank compatible properties look > a bit strange. Especially if they are all the same essentially. > > I like Sergei's idea to simply use the reg property if what you want > is really a unique ID number. What do you think about this? > > Yours, > Linus Walleij I think the 'reg' property makes more sense, yes. I'll fix this in the v5, this week-end. Do you think it can go in 4.12? Thanks, -Paul