From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F545C4338F for ; Sat, 24 Jul 2021 06:44:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B84760E9C for ; Sat, 24 Jul 2021 06:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233965AbhGXGD1 (ORCPT ); Sat, 24 Jul 2021 02:03:27 -0400 Received: from out28-73.mail.aliyun.com ([115.124.28.73]:53017 "EHLO out28-73.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbhGXGD1 (ORCPT ); Sat, 24 Jul 2021 02:03:27 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1077663|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.00401955-0.000870033-0.99511;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047194;MF=zhouyanjie@wanyeetech.com;NM=1;PH=DS;RN=5;RT=5;SR=0;TI=SMTPD_---.KpjZ-cN_1627109037; Received: from 192.168.88.130(mailfrom:zhouyanjie@wanyeetech.com fp:SMTPD_---.KpjZ-cN_1627109037) by smtp.aliyun-inc.com(10.147.40.233); Sat, 24 Jul 2021 14:43:58 +0800 Subject: Re: [PATCH 3/3] pinctrl: ingenic: Add .max_register in regmap_config To: Paul Cercueil , Linus Walleij Cc: linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210717174836.14776-1-paul@crapouillou.net> <20210717174836.14776-3-paul@crapouillou.net> From: Zhou Yanjie Message-ID: Date: Sat, 24 Jul 2021 14:43:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210717174836.14776-3-paul@crapouillou.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Paul, On 2021/7/18 上午1:48, Paul Cercueil wrote: > Compute the max register from the GPIO chip offset and number of GPIO > chips. > > This permits to read all registers from debugfs. > > Signed-off-by: Paul Cercueil > --- > drivers/pinctrl/pinctrl-ingenic.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Tested-by: 周琰杰 (Zhou Yanjie) > diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c > index 263498be8e31..2bbcb8063a16 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -3759,6 +3759,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) > void __iomem *base; > const struct ingenic_chip_info *chip_info; > struct device_node *node; > + struct regmap_config regmap_config; > unsigned int i; > int err; > > @@ -3776,8 +3777,10 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) > if (IS_ERR(base)) > return PTR_ERR(base); > > - jzpc->map = devm_regmap_init_mmio(dev, base, > - &ingenic_pinctrl_regmap_config); > + regmap_config = ingenic_pinctrl_regmap_config; > + regmap_config.max_register = chip_info->num_chips * chip_info->reg_offset; > + > + jzpc->map = devm_regmap_init_mmio(dev, base, ®map_config); > if (IS_ERR(jzpc->map)) { > dev_err(dev, "Failed to create regmap\n"); > return PTR_ERR(jzpc->map);