Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Cernekee <cernekee@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"open list:BROADCOM BMIPS MIPS ARCHITECTURE" 
	<bcm-kernel-feedback-list@broadcom.com>,
	"open list:BROADCOM BMIPS MIPS ARCHITECTURE" 
	<linux-mips@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] irqchip/irq-bcm7038-l1: Support brcm,int-fwd-mask
Date: Mon, 23 Sep 2019 09:52:41 +0100
Message-ID: <fbc07e1e-8c72-8728-2acb-647db533e31b@kernel.org> (raw)
In-Reply-To: <260e61b8-a083-743e-43fc-70b9ea644e0e@gmail.com>

On 22/09/2019 20:08, Florian Fainelli wrote:
> 
> 
> On 9/22/2019 5:38 AM, Marc Zyngier wrote:
>> On Fri, 13 Sep 2019 12:15:42 -0700
>> Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>>> On some specific chips like 7211 we need to leave some interrupts
>>> untouched/forwarded to the VPU which is another agent in the system
>>> making use of that interrupt controller hardware (goes to both ARM GIC
>>> and VPU L1 interrupt controller). Make that possible by using the
>>> existing brcm,int-fwd-mask property.
>>>
>>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>>> ---
>>>  drivers/irqchip/irq-bcm7038-l1.c | 15 +++++++++++++--
>>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
>>> index 0673a44bbdc2..811a34201dd4 100644
>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>> @@ -44,6 +44,7 @@ struct bcm7038_l1_chip {
>>>  	struct list_head	list;
>>>  	u32			wake_mask[MAX_WORDS];
>>>  #endif
>>> +	u32			irq_fwd_mask[MAX_WORDS];
>>>  	u8			affinity[MAX_WORDS * IRQS_PER_WORD];
>>>  };
>>>  
>>> @@ -265,6 +266,7 @@ static int __init bcm7038_l1_init_one(struct device_node *dn,
>>>  	resource_size_t sz;
>>>  	struct bcm7038_l1_cpu *cpu;
>>>  	unsigned int i, n_words, parent_irq;
>>> +	int ret;
>>>  
>>>  	if (of_address_to_resource(dn, idx, &res))
>>>  		return -EINVAL;
>>> @@ -278,6 +280,14 @@ static int __init bcm7038_l1_init_one(struct device_node *dn,
>>>  	else if (intc->n_words != n_words)
>>>  		return -EINVAL;
>>>  
>>> +	ret = of_property_read_u32_array(dn , "brcm,int-fwd-mask",
>>
>> What is the exact meaning of "fwd"? Forward? FirmWare Dementia?
> 
> Here it is meant to be "forward", we have defined this property name
> before for irq-bcm7120-l2.c and felt like reusing the same name to avoid
> multiplying properties would be appropriate, see patch #4. If you prefer
> something named brcm,firmware-configured-mask, let me know.

It's just a name, but I found it a bit confusing. Bah, never mind.

>>
>>> +					 intc->irq_fwd_mask, n_words);
>>> +	if (ret != 0 && ret != -EINVAL) {
>>> +		/* property exists but has the wrong number of words */
>>> +		pr_err("invalid brcm,int-fwd-mask property\n");
>>> +		return -EINVAL;
>>> +	}
>>> +
>>>  	cpu = intc->cpus[idx] = kzalloc(sizeof(*cpu) + n_words * sizeof(u32),
>>>  					GFP_KERNEL);
>>>  	if (!cpu)
>>> @@ -288,8 +298,9 @@ static int __init bcm7038_l1_init_one(struct device_node *dn,
>>>  		return -ENOMEM;
>>>  
>>>  	for (i = 0; i < n_words; i++) {
>>> -		l1_writel(0xffffffff, cpu->map_base + reg_mask_set(intc, i));
>>> -		cpu->mask_cache[i] = 0xffffffff;
>>> +		l1_writel(0xffffffff & ~intc->irq_fwd_mask[i],
>>> +			  cpu->map_base + reg_mask_set(intc, i));
>>> +		cpu->mask_cache[i] = 0xffffffff & ~intc->irq_fwd_mask[i];
>>
>> I seem to remember that (0xffffffff & whatever) == whatever, as long as
>> 'whatever' is a 32bit quantity. So what it this for?
> 
> It is 0xffff_ffff & ~whatever here.

Which doesn't change anything.

> In the absence of this property
> being specified, the data is all zeroed out, so we would have
> 0xffff_ffff & 0xffff_ffff which is 0xffff_ffff. If this property is
> specified, we would have one more or bits set, and it would be e.g.:
> 0x100 so we would have 0xffff_ffff & ~(0x100) = 0xffff_feff which is
> what we would want here to preserve whatever the firmware has already
> configured.

OK, I must be stupid:

#include <stdio.h>

int main(int argc, char *argv[])
{
	unsigned int v = 0x100;
	printf ("%x\n", ~v);
}
maz@filthy-habit$ ./x
fffffeff

You might as well OR it with zeroes, if you want.

	M.
-- 
Jazz is not dead, it just smells funny...

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 19:15 [PATCH v2 0/5] irqchip/irq-bcm7038-l1 updates Florian Fainelli
2019-09-13 19:15 ` [PATCH v2 1/5] irqchip/irq-bcm7038-l1: Add PM support Florian Fainelli
2019-09-22 12:31   ` Marc Zyngier
2019-09-22 18:50     ` Florian Fainelli
2019-09-13 19:15 ` [PATCH v2 2/5] dt-bindings: Document brcm,irq-can-wake for brcm,bcm7038-l1-intc.txt Florian Fainelli
2019-09-30 19:05   ` Rob Herring
2019-09-13 19:15 ` [PATCH v2 3/5] irqchip/irq-bcm7038-l1: Enable parent IRQ if necessary Florian Fainelli
2019-09-13 19:15 ` [PATCH v2 4/5] dt-bindings: Document brcm,int-fwd-mask property for bcm7038-l1-intc Florian Fainelli
2019-09-30 19:10   ` Rob Herring
2019-09-13 19:15 ` [PATCH v2 5/5] irqchip/irq-bcm7038-l1: Support brcm,int-fwd-mask Florian Fainelli
2019-09-22 12:38   ` Marc Zyngier
2019-09-22 19:08     ` Florian Fainelli
2019-09-23  8:52       ` Marc Zyngier [this message]
2019-09-23 14:39         ` Florian Fainelli
2019-09-23 14:57           ` Marc Zyngier
2019-09-23 15:08             ` Florian Fainelli

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbc07e1e-8c72-8728-2acb-647db533e31b@kernel.org \
    --to=maz@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cernekee@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git