From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E1BCA9EB0 for ; Sun, 3 Nov 2019 18:45:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA9ED21929 for ; Sun, 3 Nov 2019 18:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="sp5TpDxP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727603AbfKCSp3 (ORCPT ); Sun, 3 Nov 2019 13:45:29 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:45333 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727430AbfKCSp3 (ORCPT ); Sun, 3 Nov 2019 13:45:29 -0500 Received: by mail-lf1-f67.google.com with SMTP id v8so10551124lfa.12 for ; Sun, 03 Nov 2019 10:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eOdq8Hu6igUnwgJC6ijMcGO8XX2Wgr8N1NgWmkUqIi0=; b=sp5TpDxPjH4w1V6jLSm2h6J1pDcSftgxeyJArv/dQoGUI3R1XfxH5953TesJkyK5Ve xdWI5IlFQSJhV3QUwWUqpGA5MIpqYV2bF2zi/KAMmPQuWp6oFkwY+esINYEiIwGftzaf /yQd3ZisQiPyiU6tTDT7y/5zMthKbJk4yRbkTVaxNkMKrz0rvIY0xEIIT8/ELrG05F6L lHn08RFrtS92Vs4B7u3lwxSDl9dBJsCCdM718U55+QI8TjyYFSpiO4SO5qrDiVfxikYt qAQI94eyUIeNWtGmfphM4CyjMzXwyDtDqSvowudi4fdhTYU5MyKj+adEcbgssPCnF3At lZzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=eOdq8Hu6igUnwgJC6ijMcGO8XX2Wgr8N1NgWmkUqIi0=; b=pLS+FiUA+cxWCPUI+Z4ZK5joai2kvkmwsuvnDHidcwO4zhTd/Fe20F//U9x2aUHll+ sFCztpHylNfdrN93r6HkVVbSNuxzJMNUYY/3gvvp0ewJjZYJC81AW2z5B3vthrgGhhDL /YhiWPY/j90oVOkbjX5IrecSGiXvUnkEu8YFAmxEvTlOEoke/zj0JMvbvRMfBpZcmB8c meGMILCu8LqMGz2VLzn8JOcYONDFJ7Ow71zmhLa7FK84gcW/P4AvOkmwqwEl37yze1ku a7vTBncs/fT5kgt7q4lcIYq4WXK2jdaYV5yTCjH4X1pBimspIqV4BkGkDg9c+03IiVlS 2rrQ== X-Gm-Message-State: APjAAAUWjmhXXqsbf8THsJgcxmp12I9xkv8xj10sl+gAfA3W0AiYl2bI zCUE0U3crFd68ZY6AKZPZbExXA== X-Google-Smtp-Source: APXvYqydZXTIg7xJ23CQfiPJxmqJfmJseGcyxSumUlwv5YUDi6l1hRLoQlzFBxBvvoURhE6KrYUFCw== X-Received: by 2002:ac2:44d5:: with SMTP id d21mr7788722lfm.66.1572806726889; Sun, 03 Nov 2019 10:45:26 -0800 (PST) Received: from wasted.cogentembedded.com ([2a00:1fa0:47a:43f6:66fd:82d0:1ef5:f513]) by smtp.gmail.com with ESMTPSA id d16sm6152522ljh.74.2019.11.03.10.45.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Nov 2019 10:45:26 -0800 (PST) Subject: Re: [net v2 4/4] net: sgi: ioc3-eth: fix setting NETIF_F_HIGHDMA To: Thomas Bogendoerfer , Ralf Baechle , "David S. Miller" , linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christoph Hellwig References: <20191103103433.26826-1-tbogendoerfer@suse.de> <20191103103433.26826-4-tbogendoerfer@suse.de> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Sun, 3 Nov 2019 21:45:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20191103103433.26826-4-tbogendoerfer@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 11/03/2019 01:34 PM, Thomas Bogendoerfer wrote: > From: Christoph Hellwig > > Set NETIF_F_HIGHDMA together with the NETIF_F_IP_CSUM flag insted of Instead. :-) > letting the second assignment overwrite it. Probably doesn't matter > in practice as none of the systems a IOC3 is usually found in has s/a/an/ (before IOC3). > highmem to start with. > > Signed-off-by: Christoph Hellwig Your sign-off is also needed, even if you just post the other's patches. [...] MBR, Sergei