From: Alexandre Oliva <lxoliva@fsfla.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Tom Li <tomli@tomli.me>, James Hogan <jhogan@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhc@lemote.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers
Date: Sun, 17 Feb 2019 22:37:03 -0300 [thread overview]
Message-ID: <orpnrpj2rk.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <20190217235951.GA20700@darkstar.musicnaut.iki.fi> (Aaro Koskinen's message of "Mon, 18 Feb 2019 01:59:52 +0200")
On Feb 17, 2019, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> I tested few older kernels, and it seems that the spurious IRQ issue has
> been always there after switching to libata (commit 7ff7a5b1bfff). It has
> been unnoticed as the 100000 irq limit wasn't reached during boot.
I see, thanks. That would probably make it hard to bisect indeed.
>> The kernel still disables irq14 early on, and then runs slow.
> This hack works only for CONFIG_PATA_CS5536. You are probably using PATA_AMD.
That's a reasonable guess, but I don't think so. I do have PATA_AMD
enabled as a module indeed, but it's not even loaded, much as I can
tell, whereas PATA_CS5536 is built into the kernel image, and dmesg
says:
[ 4.460000] scsi host0: pata_cs5536
[ 4.464000] scsi host1: pata_cs5536
[ 4.464000] ata1: PATA max UDMA/100 cmd 0x1f0 ctl 0x3f6 bmdma 0x4c60 irq 14
[ 4.464000] ata2: DUMMY
[ 4.464000] pcnet32: [...]
[ 4.644000] random: [...]
[ 5.908000] irq 14: nobody cared (try booting with the "irqpoll" option)
Just to be sure, I added some printks to cs5536_noop_freeze, and here's
what I got in dmesg instead:
[ 4.452000] pata_cs5536: freeze: checking status...
[ 4.452000] pata_cs5536: freeze: checked, clearing...
[ 4.452000] pata_cs5536: freeze: cleared
[ 4.460000] scsi host0: pata_cs5536
[ 4.464000] scsi host1: pata_cs5536
[ 4.464000] ata1: PATA max UDMA/100 cmd 0x1f0 ctl 0x3f6 bmdma 0x4c60 irq 14
[ 4.464000] ata2: DUMMY
[ 4.464000] pcnet32: [...]
[ 4.468000] pata_cs5536: freeze: checking status...
[ 4.468000] pata_cs5536: freeze: checked, clearing...
[ 4.468000] pata_cs5536: freeze: cleared
[ 4.652000] random: [...]
[ 5.920000] irq 14: nobody cared (try booting with the "irqpoll" option)
now, maybe I just don't understand what effects the patch was supposed
to have.
The system still feels very slow, but I haven't timed anything; could it
be that it had the effect of keeping the IRQ functional after all, but
5.0-rc6 is slower than earlier kernels for other reasons? Like,
/proc/irq/14/pata_cs5536/ is there, but I haven't checked whether it was
there before the patch.
Do you suggest any way to tell whether it had the intended effect?
--
Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo
Be the change, be Free! FSF Latin America board member
GNU Toolchain Engineer Free Software Evangelist
Hay que enGNUrecerse, pero sin perder la terGNUra jamás-GNUChe
next prev parent reply other threads:[~2019-02-18 1:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 8:30 [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers Tom Li
2019-02-08 20:08 ` Paul Burton
2019-02-09 10:11 ` Tom Li
2019-02-09 19:38 ` Paul Burton
2019-02-11 12:13 ` Alexandre Oliva
2019-02-11 12:55 ` Tom Li
2019-02-11 22:38 ` Alexandre Oliva
2019-02-11 23:06 ` Aaro Koskinen
2019-02-12 4:39 ` tomli
2019-02-16 23:39 ` Alexandre Oliva
2019-02-17 4:59 ` Alexandre Oliva
2019-02-17 23:59 ` Aaro Koskinen
2019-02-18 1:37 ` Alexandre Oliva [this message]
2019-02-18 2:41 ` Maciej W. Rozycki
2019-03-07 6:41 ` Alexandre Oliva
2019-03-07 17:59 ` Maciej W. Rozycki
2019-03-08 0:46 ` Alexandre Oliva
2019-03-08 23:56 ` Maciej W. Rozycki
2019-05-26 9:19 ` Alexandre Oliva
2019-06-10 21:49 ` Aaro Koskinen
2019-06-12 5:55 ` Maciej W. Rozycki
2019-06-12 19:24 ` Aaro Koskinen
2020-01-23 0:20 ` Matt Turner
2020-01-24 18:58 ` Aaro Koskinen
2019-03-07 20:21 ` Aaro Koskinen
2019-03-07 21:22 ` Alexandre Oliva
2019-02-17 4:41 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orpnrpj2rk.fsf@lxoliva.fsfla.org \
--to=lxoliva@fsfla.org \
--cc=aaro.koskinen@iki.fi \
--cc=chenhc@lemote.com \
--cc=jhogan@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tomli@tomli.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).