Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
From: 陈华才 <chenhc@lemote.com>
To: "Paul Burton" <paul.burton@mips.com>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Cc: "Paul Burton" <pburton@wavecomp.com>
Subject: Re:[PATCH] MIPS: Drop Loongson _CACHE_* definitions
Date: Sun, 1 Sep 2019 10:41:53 +0800
Message-ID: <tencent_136CE6EE297BEA5D2910DF5B@qq.com> (raw)
In-Reply-To: <20190831154145.7328-1-paul.burton@mips.com>

Hi, Paul,

I found that _CACHE_CACHABLE_COHERENT is removed since 3.18, so this patch need to CC stable?

Huacai
 
------------------ Original ------------------
From:  "Paul Burton"<paul.burton@mips.com>;
Date:  Sat, Aug 31, 2019 11:41 PM
To:  "linux-mips@vger.kernel.org"<linux-mips@vger.kernel.org>;
Cc:  "Paul Burton"<pburton@wavecomp.com>; "Huacai Chen"<chenhc@lemote.com>;
Subject:  [PATCH] MIPS: Drop Loongson _CACHE_* definitions
 
_CACHE_CACHABLE_NONCOHERENT is defined as 3<<_CACHE_SHIFT by default, so
there's no need to define it as such specifically for Loongson.

_CACHE_CACHABLE_COHERENT is not used anywhere in the kernel, so there's
no need to define it at all.

Finally the comment found alongside these definitions seems incorrect -
it suggests that we're defining _CACHE_CACHABLE_NONCOHERENT such that it
actually provides coherence, but the opposite seems to be true & instead
the unused _CACHE_CACHABLE_COHERENT is defined as the typically
incoherent value.

Delete the whole thing, which will have no effect on the compiled code
anyway.

Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: Huacai Chen <chenhc@lemote.com>
---

 arch/mips/include/asm/pgtable-bits.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/mips/include/asm/pgtable-bits.h b/arch/mips/include/asm/pgtable-bits.h
index 5f1ced8cba07..409ae01ed7be 100644
--- a/arch/mips/include/asm/pgtable-bits.h
+++ b/arch/mips/include/asm/pgtable-bits.h
@@ -221,13 +221,6 @@ static inline uint64_t pte_to_entrylo(unsigned long pte_val)
 
 #define _CACHE_CACHABLE_NONCOHERENT (5<<_CACHE_SHIFT)
 
-#elif defined(CONFIG_CPU_LOONGSON3)
-
-/* Using COHERENT flag for NONCOHERENT doesn't hurt. */
-
-#define _CACHE_CACHABLE_NONCOHERENT (3<<_CACHE_SHIFT)  /* LOONGSON       */
-#define _CACHE_CACHABLE_COHERENT    (3<<_CACHE_SHIFT)  /* LOONGSON-3     */
-
 #elif defined(CONFIG_MACH_INGENIC)
 
 /* Ingenic uses the WA bit to achieve write-combine memory writes */
-- 
2.22.1

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 15:41 [PATCH] " Paul Burton
2019-09-01  2:41 ` 陈华才 [this message]
2019-09-02  0:47   ` Jiaxun Yang
2019-09-01 22:53 ` Philippe Mathieu-Daudé
2019-09-02  0:51 ` Jiaxun Yang
2019-09-03 20:47 ` Paul Burton

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_136CE6EE297BEA5D2910DF5B@qq.com \
    --to=chenhc@lemote.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=pburton@wavecomp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org linux-mips@archiver.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/ public-inbox