Linux-MIPS Archive on
 help / color / Atom feed
From: 陈华才 <>
To: "Paul Burton" <>,
	"" <>
Cc: "Paul Burton" <>
Subject: Re:[PATCH] MIPS: Drop Loongson _CACHE_* definitions
Date: Sun, 1 Sep 2019 10:41:53 +0800
Message-ID: <> (raw)
In-Reply-To: <>

Hi, Paul,

I found that _CACHE_CACHABLE_COHERENT is removed since 3.18, so this patch need to CC stable?

------------------ Original ------------------
From:  "Paul Burton"<>;
Date:  Sat, Aug 31, 2019 11:41 PM
To:  ""<>;
Cc:  "Paul Burton"<>; "Huacai Chen"<>;
Subject:  [PATCH] MIPS: Drop Loongson _CACHE_* definitions
_CACHE_CACHABLE_NONCOHERENT is defined as 3<<_CACHE_SHIFT by default, so
there's no need to define it as such specifically for Loongson.

_CACHE_CACHABLE_COHERENT is not used anywhere in the kernel, so there's
no need to define it at all.

Finally the comment found alongside these definitions seems incorrect -
it suggests that we're defining _CACHE_CACHABLE_NONCOHERENT such that it
actually provides coherence, but the opposite seems to be true & instead
the unused _CACHE_CACHABLE_COHERENT is defined as the typically
incoherent value.

Delete the whole thing, which will have no effect on the compiled code

Signed-off-by: Paul Burton <>
Cc: Huacai Chen <>

 arch/mips/include/asm/pgtable-bits.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/mips/include/asm/pgtable-bits.h b/arch/mips/include/asm/pgtable-bits.h
index 5f1ced8cba07..409ae01ed7be 100644
--- a/arch/mips/include/asm/pgtable-bits.h
+++ b/arch/mips/include/asm/pgtable-bits.h
@@ -221,13 +221,6 @@ static inline uint64_t pte_to_entrylo(unsigned long pte_val)
-#elif defined(CONFIG_CPU_LOONGSON3)
-/* Using COHERENT flag for NONCOHERENT doesn't hurt. */
 #elif defined(CONFIG_MACH_INGENIC)
 /* Ingenic uses the WA bit to achieve write-combine memory writes */

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 15:41 [PATCH] " Paul Burton
2019-09-01  2:41 ` 陈华才 [this message]
2019-09-02  0:47   ` Jiaxun Yang
2019-09-01 22:53 ` Philippe Mathieu-Daudé
2019-09-02  0:51 ` Jiaxun Yang
2019-09-03 20:47 ` Paul Burton

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-MIPS Archive on

Archives are clonable:
	git clone --mirror linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ \
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox