From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B62C433FE for ; Thu, 17 Nov 2022 14:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240393AbiKQOZc (ORCPT ); Thu, 17 Nov 2022 09:25:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240367AbiKQOZK (ORCPT ); Thu, 17 Nov 2022 09:25:10 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0CE21CFEC for ; Thu, 17 Nov 2022 06:24:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668695044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ero3Dop74ZUrxw/cst3yMxEJhDrRdAAQvlUsX3escHg=; b=EiyWF2bGgWI+mcYml0p3NT1eUHswn0yo8fN97sETrVTu0yNhR8B9fISPaU7QyJH/skF9+S g5l3gbBMW2kBvyKzEtuKkZoui8g6ZMh5oMWucmQ3QANBwlHB97EZ6X1Yt4rX+boerqHC2U 2WbHL7ExO/PAM0If3bHFiTYW/fkXcoQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-613-qVPqA1e6OUSz7UaAa4CdQA-1; Thu, 17 Nov 2022 09:24:01 -0500 X-MC-Unique: qVPqA1e6OUSz7UaAa4CdQA-1 Received: by mail-wm1-f71.google.com with SMTP id ay40-20020a05600c1e2800b003cf8aa16377so701816wmb.7 for ; Thu, 17 Nov 2022 06:24:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ero3Dop74ZUrxw/cst3yMxEJhDrRdAAQvlUsX3escHg=; b=N+aSA0lbHSqpec1XMvBaGmcnYGvk0r1oTT3bU8yRZMSh/j18pBKIX9bc4B76DlwLbD ZNc82S41cKj9uIyvdjibPpsOh1bFrsHLVw1DkvRqfbYP24YcnfHwlJVgrlHePNeal73n +gdvy2nf1ZmpKgFS+hpHKQNp2f0SXTxKs/OYInQ+/+7lBeHsT59P1iQSmVAvlwK4ywvg VmHlI0OouJTjIyqVEnz4trWCJO21fdnzxI8ZpzMoV+ScmUV37liHL5W7RGOlsRflw4zV JHRs1epw6HCdqJnwHmuKgCl4HWeHsx88urxSTnsJ6bhXbbsux+TtvXMivzjz90CMdLnu /v5A== X-Gm-Message-State: ANoB5pnIjwneUHW1z371OLUw6bLggAlBkbleAU5OyJN836FqT0zA9OHe OeeR9qvxribqdSTyDQqqmFfvJvIPy8ZWwUSvxyN3CnCMZcimFBM7YPdynJyX/fm5KEbAww47to6 gCA6Q9ginuGVVSWUvaQQoDA== X-Received: by 2002:a5d:58fb:0:b0:236:74c5:1b2d with SMTP id f27-20020a5d58fb000000b0023674c51b2dmr1616735wrd.14.1668695040746; Thu, 17 Nov 2022 06:24:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf7dCrVGloFO6BdNbsi4gADz4iCuS/nJ5b5vEmtvQw4WeirpWLMINwzrWmZ6QxU1sPuLDe40QQ== X-Received: by 2002:a5d:58fb:0:b0:236:74c5:1b2d with SMTP id f27-20020a5d58fb000000b0023674c51b2dmr1616704wrd.14.1668695040586; Thu, 17 Nov 2022 06:24:00 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id t11-20020adff60b000000b0022e035a4e93sm1096445wrp.87.2022.11.17.06.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 06:23:59 -0800 (PST) From: Valentin Schneider To: Peter Zijlstra Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, "Paul E. McKenney" , Steven Rostedt , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Frederic Weisbecker , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Marc Zyngier , Mark Rutland , Russell King , Nicholas Piggin , Guo Ren , "David S. Miller" Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask() In-Reply-To: References: <20221102182949.3119584-1-vschneid@redhat.com> <20221102183336.3120536-3-vschneid@redhat.com> Date: Thu, 17 Nov 2022 14:23:55 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 17/11/22 10:08, Peter Zijlstra wrote: > On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote: >> This simply wraps around the arch function and prepends it with a >> tracepoint, similar to send_call_function_single_ipi(). >> >> Signed-off-by: Valentin Schneider >> --- >> kernel/smp.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/kernel/smp.c b/kernel/smp.c >> index e2ca1e2f31274..c4d561cf50d45 100644 >> --- a/kernel/smp.c >> +++ b/kernel/smp.c >> @@ -160,6 +160,13 @@ void __init call_function_init(void) >> smpcfd_prepare_cpu(smp_processor_id()); >> } >> >> +static inline void > > Given the use of _RET_IP_, I would strongly recommend you use > __always_inline. > Noted, thanks >> +send_call_function_ipi_mask(const struct cpumask *mask) >> +{ >> + trace_ipi_send_cpumask(mask, _RET_IP_, func); > > What's func? > A rebase fail... That's only plugged in later. >> + arch_send_call_function_ipi_mask(mask); >> +}