From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31422C55178 for ; Fri, 6 Nov 2020 15:55:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85B1E22203 for ; Fri, 6 Nov 2020 15:55:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bsRXBzg4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B1E22203 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B1B56B006C; Fri, 6 Nov 2020 10:55:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 071166B0070; Fri, 6 Nov 2020 10:55:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E92F86B006E; Fri, 6 Nov 2020 10:55:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id AC57A6B0068 for ; Fri, 6 Nov 2020 10:55:26 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5B3698249980 for ; Fri, 6 Nov 2020 15:55:26 +0000 (UTC) X-FDA: 77454443052.01.milk72_2f14898272d3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 377E010047854 for ; Fri, 6 Nov 2020 15:55:26 +0000 (UTC) X-HE-Tag: milk72_2f14898272d3 X-Filterd-Recvd-Size: 7037 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 15:55:24 +0000 (UTC) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 06 Nov 2020 23:55:19 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Nov 2020 15:55:18 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.55) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 6 Nov 2020 15:55:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Izw69P4sFmyQTENqCV0SaD7ej7OdXTB3q1zR0nEt3Cw+NzchOKuYcZOmUNDA6Oj8MxlJNGPrv87H6P+3gzs/kHjhHgxrhVUSYRyI5CJcgF9GHgMDwoFIvvjut7UzKGGFrRpEbp3fIZImPdLe8SIOzQKBszAGe0ZJpByDMIEz1LiZIiU0m2mb7ajJVhb6deoxi7jZ+Nw+eucRpYTAeBM96lHyedSkHb3DOB1WzNbsdqZwzPC3dn8DoDs1ETElhjEvaRfj4/jiAFy8ihVo+RgYj1Wm2m+HKWAkEnX87lazw/CQRNmmTKKkkPlwL0AgDNIZTbDQonrrjptFruVlpc6v/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y4Qy+oLPmuyVMsQaxEZxutdixiNMMD8gkxyVmg4tMGQ=; b=W+cXmJjf00FUO08wP53bfeBJj5nx31PoYPgWQ9eBBPyAuBo9GtsE4k1jYvbsLOND5ppc8PfPhZtsDTi33CNt4BhrDZ/m7wwpBtwKdYuFMA6OfehqNj0rqm513lLXKL0QLhJmY+QJkbqnCNcaWiYIaTEumaMmia4/ny722FDJY4wUXkTEe7VGl8DhdIVt3i2zuQ9UQmimzr2SxjNRwTlilYQlbYv6TAa1oaitR9KVxUWseV+sKx8Muzx27I+pcuHvZ6v5j/PuKzf5obLazYAU+L6TxzAH/PJ2NAnF6TSDWvY6m3/xanB7778gB+Ngz21hU0LHtwG0erUWCLrM/8Jilw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3834.namprd12.prod.outlook.com (2603:10b6:5:14a::12) by DM6PR12MB4617.namprd12.prod.outlook.com (2603:10b6:5:35::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 6 Nov 2020 15:55:16 +0000 Received: from DM6PR12MB3834.namprd12.prod.outlook.com ([fe80::cdbe:f274:ad65:9a78]) by DM6PR12MB3834.namprd12.prod.outlook.com ([fe80::cdbe:f274:ad65:9a78%7]) with mapi id 15.20.3499.032; Fri, 6 Nov 2020 15:55:16 +0000 From: Jason Gunthorpe To: , Peter Xu , Linus Torvalds CC: "Ahmed S. Darwish" , Andrea Arcangeli , Andrew Morton , Aneesh Kumar K.V , Christoph Hellwig , Hugh Dickins , Jan Kara , Jann Horn , John Hubbard , Kirill Shutemov , Kirill Tkhai , Leon Romanovsky , Linux-MM , Michal Hocko , Oleg Nesterov Subject: [PATCH v3 0/2] Add a seqcount between gup_fast and copy_page_range() Date: Fri, 6 Nov 2020 11:55:12 -0400 Message-ID: <0-v3-7358966cab09+14e9-gup_fork_jgg@nvidia.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-ClientProxiedBy: MN2PR04CA0020.namprd04.prod.outlook.com (2603:10b6:208:d4::33) To DM6PR12MB3834.namprd12.prod.outlook.com (2603:10b6:5:14a::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mlx.ziepe.ca (156.34.48.30) by MN2PR04CA0020.namprd04.prod.outlook.com (2603:10b6:208:d4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 6 Nov 2020 15:55:15 +0000 Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kb454-000vSk-B1; Fri, 06 Nov 2020 11:55:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604678119; bh=j+kIuZ0lK5KiIT4Ebi/8Z2RmX4RefiP5M2kW/JXd4Qc=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Date:Message-ID:Content-Transfer-Encoding:Content-Type: X-ClientProxiedBy:MIME-Version: X-MS-Exchange-MessageSentRepresentingType; b=bsRXBzg4+vg0H0MbUnpcC3WwUriy8pnw+ErvhicNr8Avsk9nNOjdrCRJn0iEiswWx u7zjFi8Ac1SzhfmIxMiKZJwSfKVGfKOsYO15OUAiXiy5BKXTjvA4StK7ukZHQLaBdY g8lOfVJp1BY+UdmbkHhbrTRmh/Rk+hDRzsVJHGtX0ZVQeVHl2MbEu6d8KIJ+B9NjYz Fo0tkLZPSQeBglCpMBbrY2czkb1TcyuC4J8qzS0uNRvy8BUMEhGptjJi5Mu+FhOQph AKWQ337zEcCjjXHLXtp/vOS4an0wiz/WoiVLAACpe5EsVQ1pWAbgcQ3/4yMnnUOOAP QHKP+dRR7vcJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As discussed and suggested by Linus use a seqcount to close the small race between gup_fast and copy_page_range(). Ahmed confirms that raw_write_seqcount_begin() is the correct API to use in this case and it doesn't trigger any lockdeps. I was able to test it using two threads, one forking and the other using ibv_reg_mr() to trigger GUP fast. Modifying copy_page_range() to sleep made the window large enough to reliably hit to test the logic. v3: - Revise comment for write_protect_seq - Revise comment in copy_page_range - Use raw_write_seqcount_begin() not raw_write_seqcount_t_begin() v2: https://lore.kernel.org/r/0-v2-dfe9ecdb6c74+2066-gup_fork_jgg@nvidia.co= m - Use start not addr in lockless_pages_from_mm - Replace unsigned long casts with using the proper variable type - Update comments - Use raw_write_seqcount_t_begin() instead of open coding - Update commit messages v1: https://lore.kernel.org/r/0-v1-281e425c752f+2df-gup_fork_jgg@nvidia.com To: linux-kernel@vger.kernel.org To: Peter Xu To: Linus Torvalds Cc: Peter Xu Cc: John Hubbard Cc: Linux-MM Cc: Linux Kernel Mailing List Cc: Andrew Morton Cc: Jan Kara Cc: Michal Hocko Cc: Kirill Tkhai Cc: Kirill Shutemov Cc: Hugh Dickins Cc: Christoph Hellwig Cc: Andrea Arcangeli Cc: Oleg Nesterov Cc: Jann Horn Cc: "Ahmed S. Darwish" Jason Gunthorpe (2): mm: reorganize internal_get_user_pages_fast() mm: prevent gup_fast from racing with COW during fork arch/x86/kernel/tboot.c | 1 + drivers/firmware/efi/efi.c | 1 + include/linux/mm_types.h | 8 +++ kernel/fork.c | 1 + mm/gup.c | 118 +++++++++++++++++++++++-------------- mm/init-mm.c | 1 + mm/memory.c | 13 +++- 7 files changed, 97 insertions(+), 46 deletions(-) --=20 2.29.2