Yes, the original code using scale should be about rounding to integer.
I am trying to improve the calculation because i think the rounding seems to be useless, we can calculate pressure directly just like original code of "pressure = pressure * 100 / scale", no floating number issue.
From the view of disassembly, the patch is also better than original.
If original code using scale is more powerful than the patch, please ignore the submit.
Thanks.
------------------------------------------------------------------
发件人：Michal Hocko <mhocko@kernel.org>
发送时间：2017年7月3日(星期一) 18:24
收件人：zbestahu@aliyun.com <zbestahu@aliyun.com>
抄 送：akpm <akpm@linux-foundation.org>; minchan <minchan@kernel.org>; linux-mm <linux-mm@kvack.org>; Yue Hu <huyue2@coolpad.com>; Anton Vorontsov <anton.vorontsov@linaro.org>
主 题：Re: [PATCH] mm: vmpressure: simplify pressure ratio calculation
On Mon 03-07-17 17:45:25, zbestahu@aliyun.com wrote:
> Hi Michal
>
> We can think the some of scanned pages is reclaimed as reclaimed pages
> and the rest of pages is just unsuccessful reclaimed pages. vmpressure
> is tend to unsuccessful reclaimed pages, so obviously the pressure
> percent is the ratio of unsuccessful reclaimed pages to scanned pages.
Yes this is correct and this is what the current code does as well.
The difference is in the rounding when the integer arithmetic is used.
Btw. are you trying to fix any existing problem or you merely checked
the code and considered this part too hard to understand and so you sent
a patch to make it simpler? Have you considered the original intention
of the code? Note that I am not saying your patch is incorrect I would
just like to uderstand your motivation and the original intention in the
code.
> -------- 原始邮件 --------
> 发件人：Michal Hocko <mhocko@kernel.org>
> 时间：周一 7月3日 15:44
> 收件人：zbestahu <zbestahu@aliyun.com>
> 抄送：akpm <akpm@linux-foundation.org>,minchan <minchan@kernel.org>,linux-mm <linux-mm@kvack.org>,Yue Hu <huyue2@coolpad.com>,Anton Vorontsov <anton.vorontsov@linaro.org>
> 主题：Re: [PATCH] mm: vmpressure: simplify pressure ratio calculation
>
> >[CC Anton]
> >
> >On Sat 01-07-17 14:27:39, zbestahu@aliyun.com wrote:
> >> From: Yue Hu <huyue2@coolpad.com>
> >>
> >> The patch removes the needless scale in existing caluation, it
> >> makes the calculation more simple and more effective.
> >
> >I suspect the construct is deliberate and done this way because of the
> >rounding. Your code will behave slightly differently. If that is
> >intentional then it should be described in the changedlog.
> >
> >> Signed-off-by: Yue Hu <huyue2@coolpad.com>
> >> ---
> >> mm/vmpressure.c | 4 +---
> >> 1 file changed, 1 insertion(+), 3 deletions(-)
> >>
> >> diff --git a/mm/vmpressure.c b/mm/vmpressure.c
> >> index 6063581..174b2f0 100644
> >> --- a/mm/vmpressure.c
> >> +++ b/mm/vmpressure.c
> >> @@ -111,7 +111,6 @@ static enum vmpressure_levels vmpressure_level(unsigned long pressure)
> >> static enum vmpressure_levels vmpressure_calc_level(unsigned long scanned,
> >> unsigned long reclaimed)
> >> {
> >> - unsigned long scale = scanned + reclaimed;
> >> unsigned long pressure = 0;
> >>
> >> /*
> >> @@ -128,8 +127,7 @@ static enum vmpressure_levels vmpressure_calc_level(unsigned long scanned,
> >> * scanned. This makes it possible to set desired reaction time
> >> * and serves as a ratelimit.
> >> */
> >> - pressure = scale - (reclaimed * scale / scanned);
> >> - pressure = pressure * 100 / scale;
> >> + pressure = (scanned - reclaimed) * 100 / scanned;
> >>
> >> out:
> >> pr_debug("%s: %3lu (s: %lu r: %lu)\n", __func__, pressure,
> >> --
> >> 1.9.1
> >>
> >
> >--
> >Michal Hocko
> >SUSE Labs
--
Michal Hocko
SUSE Labs