From: William Kucharski <william.kucharski@oracle.com>
To: Jane Chu <jane.chu@oracle.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: hwpoison: use do_send_sig_info() instead of force_sig() (Re: PMEM error-handling forces SIGKILL causes kernel panic)
Date: Thu, 17 Jan 2019 02:44:58 -0700 [thread overview]
Message-ID: <00575D78-10FE-4A05-9BAB-5A2992AB401D@oracle.com> (raw)
In-Reply-To: <6fa27824-d86d-f642-db7c-a13faaac527d@oracle.com>
> On Jan 16, 2019, at 6:07 PM, Jane Chu <jane.chu@oracle.com> wrote:
>
> It's just coding style I'm used to, no big deal.
> Up to you to decide. :)
Personally I like a (void) cast as it's pretty long-standing syntactic sugar to cast a call that returns a value we don't care about to (void) to show we know it returns a value and we don't care.
Without it, it may suggest we either didn't know it returned a value or that we neglected to check the return value.
However, in current use elsewhere (e.g. in send_sig_all() and __oom_kill_process()), no such (void) cast is added, so it seems better to match current usage elsewhere in the kernel.
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
prev parent reply other threads:[~2019-01-17 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e3c4c0e0-1434-4353-b893-2973c04e7ff7@oracle.com>
[not found] ` <CAPcyv4j67n6H7hD6haXJqysbaauci4usuuj5c+JQ7VQBGngO1Q@mail.gmail.com>
[not found] ` <20190111081401.GA5080@hori1.linux.bs1.fc.nec.co.jp>
2019-01-16 9:30 ` [PATCH] mm: hwpoison: use do_send_sig_info() instead of force_sig() (Re: PMEM error-handling forces SIGKILL causes kernel panic) Naoya Horiguchi
2019-01-16 9:30 ` Naoya Horiguchi
2019-01-16 16:55 ` Dan Williams
2019-01-16 16:55 ` Dan Williams
2019-01-16 17:20 ` Jane Chu
2019-01-16 17:20 ` Jane Chu
2019-01-16 17:56 ` Jane Chu
2019-01-16 23:32 ` Naoya Horiguchi
2019-01-17 1:07 ` Jane Chu
2019-01-17 9:44 ` William Kucharski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00575D78-10FE-4A05-9BAB-5A2992AB401D@oracle.com \
--to=william.kucharski@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jane.chu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).