From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D2EC433C1 for ; Fri, 19 Mar 2021 18:48:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 944E661980 for ; Fri, 19 Mar 2021 18:48:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 944E661980 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC37B6B006E; Fri, 19 Mar 2021 14:48:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E73B46B0070; Fri, 19 Mar 2021 14:48:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CED136B0071; Fri, 19 Mar 2021 14:48:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id B501B6B006E for ; Fri, 19 Mar 2021 14:48:25 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 667D91EF1 for ; Fri, 19 Mar 2021 18:48:25 +0000 (UTC) X-FDA: 77937509370.20.7C778C5 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 8C8908019AFF for ; Fri, 19 Mar 2021 18:48:24 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id o10so11523265lfb.9 for ; Fri, 19 Mar 2021 11:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yYYW5DnVy84/4kP9GQaKkhK/K8GjeKuwEY0DFeSN6Tg=; b=JTkd1WijALfGVwHAIoHlFxO8p7v7gsY+v3XsU4ro23Xiuebo+6inwyLeom2X3oieeR Rxbht7CJ9Cph507VFPJyZCyfBvXEDvxP4DDgrQupKDDvoY0SXyX7oFdES54kUaFcKOSf KMF+M9SMWxPRD87A4nUsCQaoqQMtxMuweDb1qhZCK67kH68m89fjECpPs82IPsD/4q7G 9A8B++/bytkP118iuQBWU27wQN0BsODSkIDVUnCSqD4X63mwLwopetQrQajalwBSP2Ch ve8nkl3nzABqJUBkXLw55WpYmTKsS2+w9zJEMYEBtoFwXxujuI3FxMAujL0UPr9W/q/a OrWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yYYW5DnVy84/4kP9GQaKkhK/K8GjeKuwEY0DFeSN6Tg=; b=qqPKiRvwGxjZM/i/DQD/mznU5yf859cDAt/pZ+NRFHTpnG+hGkMJEZ84uVODoA357E lZpldi4ZFL+XZv2+fc9dD/o3EEiqXblrxCA4lrrerFij/blEzlW9Gzu/mCC7NLAvoCbO /w+oQXL46hHn2v5tqX+J8rRGFtacXBg6MOghnrAvj2tEei95lGOxhyXuK7QGqELKV/1k I5VEuAzfPFkB0ZhCKz9jj18EaMl/rusXnZNF0ZqbYkkSDVpxsokP2W1xY/eMq/4sq9y/ XeGvrtywFlKiSiHwrtMomnIb02zX4E/PUl/3zXaCcQSeHGZSDeYAPSkzMZom5KofgLZR H+Ew== X-Gm-Message-State: AOAM530kWjr0NorkMbhIw2QCUsx0ORSd5ZUS0SWcNFu8kPdNn+e2Doag 9ihK1V9UiVDR1GVAPcCvndM= X-Google-Smtp-Source: ABdhPJzfZwvhL9QOMDPUSINsEPmuq4pkpT82W3ZXu8vQCjJ+UoyheGgwRO6vRplbFKl7HgrIFiC7tA== X-Received: by 2002:ac2:454d:: with SMTP id j13mr1586740lfm.129.1616179692482; Fri, 19 Mar 2021 11:48:12 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id j8sm871890lji.8.2021.03.19.11.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 11:48:12 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Minchan Kim Cc: Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <071c6681-f492-2c94-5686-30c30778f39d@gmail.com> From: Dmitry Osipenko Message-ID: <007c0317-8819-a6b8-fdff-c0b5899c4f51@gmail.com> Date: Fri, 19 Mar 2021 21:48:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: ymd3gzmwzuq1zzb14wxoi4bqqk933hba X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8C8908019AFF Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-lf1-f43.google.com; client-ip=209.85.167.43 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616179704-407716 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 21:21, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Fri, Mar 19, 2021 at 08:56:06PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 19:30, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> +static void cma_kobj_release(struct kobject *kobj) >>> +{ >>> + struct cma_kobject *cma_kobj =3D container_of(kobj, struct cma_kobj= ect, kobj); >>> + >>> + kfree(cma_kobj); >>> +} >> >> Oh, wait.. I think this kfree wrong since cma_kobj belongs to the arra= y. >=20 > Oh, good spot. Let me use kzalloc. >=20 Thinking a bit more about this.. it looks like actually it should be better to get back to the older variant of cma_stat, but allocate at the time of CMA initialization, rather than at the time of sysfs initialization. Then the cma_stat will be decoupled from the cma struct and cma_stat will be a self-contained object.