From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B933FC433B4 for ; Thu, 6 May 2021 18:36:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22DD460C3D for ; Thu, 6 May 2021 18:36:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22DD460C3D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8EE326B006C; Thu, 6 May 2021 14:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89D5B6B006E; Thu, 6 May 2021 14:36:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 717556B0070; Thu, 6 May 2021 14:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 5628A6B006C for ; Thu, 6 May 2021 14:36:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0DA97180AD838 for ; Thu, 6 May 2021 18:36:35 +0000 (UTC) X-FDA: 78111661950.14.CC9CF5B Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf28.hostedemail.com (Postfix) with ESMTP id 1C0A02000262 for ; Thu, 6 May 2021 18:36:33 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 146IKDhr169383; Thu, 6 May 2021 18:36:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=7slUrep9Nu26y6m09Y38ht4Cg+iPIyfQgVWBhX/oQT4=; b=fmE84Wi0U2cHeQKpv7Z/t0JKxsT55sWRjV17fYENMBbivvEQyenA4vhIGLPuCsHV0Exs pW8TEq21XDidIh9oT4eambBblrlmbGb5sYJLT3dDXSXoET0fv3lsg3QGk6koRtlvrGOL z0MCUGEyf/I+3oaeK1IcJcel4rHUMmBmTCmrSeHLOc0KiIWGjFhfR2PvlcTMzGQscfZS XhUnqU0GYSKb7Zdxf2VfCvmyvO6mIwJZe8rioZhs7/lnQ/gYJ40LCjV1+3SBtYNLylUi TLDLXCuyiGFPBVOoHYq/tcYvmk9w93KML5BuZfcAQ9+qg7kpXcisjd1pEnLBq7vSKzLc fg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 38bemjnx7t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 May 2021 18:36:29 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 146IaMQX174186; Thu, 6 May 2021 18:36:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3020.oracle.com with ESMTP id 38bebmwajq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 May 2021 18:36:29 +0000 Received: from aserp3020.oracle.com (aserp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 146IaSM0175707; Thu, 6 May 2021 18:36:28 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 38bebmwahj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 May 2021 18:36:28 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 146IaNWt000863; Thu, 6 May 2021 18:36:23 GMT Received: from [10.175.182.44] (/10.175.182.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 May 2021 11:36:23 -0700 Subject: Re: [PATCH v1 06/11] mm/sparse-vmemmap: refactor vmemmap_populate_basepages() From: Joao Martins To: Dan Williams Cc: Linux MM , Ira Weiny , linux-nvdimm , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton References: <20210325230938.30752-1-joao.m.martins@oracle.com> <20210325230938.30752-7-joao.m.martins@oracle.com> Message-ID: <00d349e3-eb3e-5048-56b0-9c44b56f4b75@oracle.com> Date: Thu, 6 May 2021 19:36:19 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: VxEvGVqxoCgvFKb9f9Lz3nXXp6J_fwGq X-Proofpoint-GUID: VxEvGVqxoCgvFKb9f9Lz3nXXp6J_fwGq X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9976 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 mlxscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105060127 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=fmE84Wi0; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf28.hostedemail.com: domain of joao.m.martins@oracle.com has no SPF policy when checking 141.146.126.78) smtp.mailfrom=joao.m.martins@oracle.com X-Stat-Signature: koex5hstyw8qc65ie5n1jr89fazhcwyw X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1C0A02000262 Received-SPF: none (oracle.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=aserp2120.oracle.com; client-ip=141.146.126.78 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620326193-259612 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/6/21 11:27 AM, Joao Martins wrote: > On 5/5/21 11:43 PM, Dan Williams wrote: >> I suspect it's a good sign I'm only finding cosmetic and changelog >> changes in the review... > > Hopefully it continues that way, but the meat of the series is located > in patches 4, 6, 7 and 11. *Specially* 6 and 7. > Ugh, I meant 7 and 8 *not* 6 and 7. > I very strongly suspect I am gonna get non-cosmetic comments there.