From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBCFC433E3 for ; Wed, 26 Aug 2020 09:01:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C620A2075E for ; Wed, 26 Aug 2020 09:01:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C620A2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AA9D6B0006; Wed, 26 Aug 2020 05:01:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 659196B0007; Wed, 26 Aug 2020 05:01:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54AAD8D0002; Wed, 26 Aug 2020 05:01:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 3784F6B0006 for ; Wed, 26 Aug 2020 05:01:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E2031824805A for ; Wed, 26 Aug 2020 09:01:10 +0000 (UTC) X-FDA: 77192125500.07.list67_2b1201d27063 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id B723D1803F9AB for ; Wed, 26 Aug 2020 09:01:10 +0000 (UTC) X-HE-Tag: list67_2b1201d27063 X-Filterd-Recvd-Size: 9861 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Aug 2020 09:01:09 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04427;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0U6uVqlE_1598432457; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U6uVqlE_1598432457) by smtp.aliyun-inc.com(127.0.0.1); Wed, 26 Aug 2020 17:01:02 +0800 Subject: Re: [PATCH v18 00/32] per memcg lru_lock To: Daniel Jordan Cc: Hugh Dickins , Andrew Morton , mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com References: <1598273705-69124-1-git-send-email-alex.shi@linux.alibaba.com> <20200824114204.cc796ca182db95809dd70a47@linux-foundation.org> <20200825015627.3c3pnwauqznnp3gc@ca-dmjordan1.us.oracle.com> <20200826011946.spknwjt44d2szrdo@ca-dmjordan1.us.oracle.com> From: Alex Shi Message-ID: <01ed6e45-3853-dcba-61cb-b429a49a7572@linux.alibaba.com> Date: Wed, 26 Aug 2020 16:59:28 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200826011946.spknwjt44d2szrdo@ca-dmjordan1.us.oracle.com> Content-Type: multipart/mixed; boundary="------------7C4509CD50BDF422F0129A10" X-Rspamd-Queue-Id: B723D1803F9AB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a multi-part message in MIME format. --------------7C4509CD50BDF422F0129A10 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E5=9C=A8 2020/8/26 =E4=B8=8A=E5=8D=889:19, Daniel Jordan =E5=86=99=E9=81= =93: > On Tue, Aug 25, 2020 at 11:26:58AM +0800, Alex Shi wrote: >> =E5=9C=A8 2020/8/25 =E4=B8=8A=E5=8D=889:56, Daniel Jordan =E5=86=99=E9= =81=93: >>> Alex, do you have a pointer to the modified readtwice case? >> >> Sorry, no. my developer machine crashed, so I lost case my container a= nd modified >> case. I am struggling to get my container back from a account problema= tic repository.=20 >> >> But some testing scripts is here, generally, the original readtwice ca= se will >> run each of threads on each of cpus. The new case will run one contain= er on each cpus, >> and just run one readtwice thead in each of containers. >=20 > Ok, what you've sent so far gives me an idea of what you did. My readt= wice > changes were similar, except I used the cgroup interface directly inste= ad of > docker and shared a filesystem between all the cgroups whereas it looks= like > you had one per memcg. 30 second runs on 5.9-rc2 and v18 gave 11% more= data > read with v18. This was using 16 cgroups (32 dd tasks) on a 40 CPU, 2 = socket > machine. I clean up my testing and make it reproducable by a Dockerfile and a case= patch which attached.=20 User can build a container from the file, and then do testing like follow= ing: #start some testing containers for ((i=3D0; i< 80; i++)); do docker run --privileged=3Dtrue --rm lrulock= bash -c " sleep 20000" & done #do testing evn setup=20 for i in `docker ps | sed '1 d' | awk '{print $1 }'` ;do docker exec --pr= ivileged=3Dtrue -it $i bash -c "cd vm-scalability/; bash -x ./case-lru-fi= le-readtwice m"& done #kick testing for i in `docker ps | sed '1 d' | awk '{print $1 }'` ;do docker exec --pr= ivileged=3Dtrue -it $i bash -c "cd vm-scalability/; bash -x ./case-lru-fi= le-readtwice r"& done #show result for i in `docker ps | sed '1 d' | awk '{print $1 }'` ;do echo =3D=3D=3D $= i =3D=3D=3D; docker exec $i bash -c 'cat /tmp/vm-scalability-tmp/dd-outpu= t-* ' & done | grep MB | awk 'BEGIN {a=3D0;} { a+=3D$10 } END {print NR,= a/(NR)}' This time, on a 2P * 20 core * 2 HT machine, This readtwice performance is 252% compare to v5.9-rc2 kernel. A good sur= prise! >=20 >>> Even better would be a description of the problem you're having in pr= oduction >>> with lru_lock. We might be able to create at least a simulation of i= t to show >>> what the expected improvement of your real workload is. >> >> we are using thousands memcgs in a machine, but as a simulation, I gue= ss above case >> could be helpful to show the problem. >=20 > Using thousands of memcgs to do what? Any particulars about the type o= f > workload? Surely it's more complicated than page cache reads :) Yes, the workload are quit different on different business, some use cpu = a lot, some use memory a lot, and some are may mixed. For containers number, that are als= o quit various from tens to hundreds to thousands. >=20 >>> I ran a few benchmarks on v17 last week (sysbench oltp readonly, kern= devel from >>> mmtests, a memcg-ized version of the readtwice case I cooked up) and = then today >>> discovered there's a chance I wasn't running the right kernels, so I'= m redoing >>> them on v18. >=20 > Neither kernel compile nor git checkout in the root cgroup changed much= , just > 0.31% slower on elapsed time for the compile, so no significant regress= ions > there. Now for sysbench again. >=20 Thanks a lot for testing report! Alex --------------7C4509CD50BDF422F0129A10 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="Dockerfile" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="Dockerfile" RlJPTSBjZW50b3M6OApNQUlOVEFJTkVSIEFsZXhzIAojV09SS0RJUiAvdm0tc2NhbGFiaWxp dHkgCiNSVU4geXVtIHVwZGF0ZSAteSAmJiB5dW0gZ3JvdXBpbnN0YWxsICJEZXZlbG9wbWVu dCBUb29scyIgLXkgJiYgeXVtIGNsZWFuIGFsbCAmJiBcCiNleGFtcGxlcyBodHRwczovL3d3 dy5saW51eHRlY2hpLmNvbS9idWlsZC1kb2NrZXItY29udGFpbmVyLWltYWdlcy13aXRoLWRv Y2tlcmZpbGUvClJVTiB5dW0gaW5zdGFsbCBnaXQgeGZzcHJvZ3MgcGF0Y2ggbWFrZSBnY2Mg LXkgJiYgeXVtIGNsZWFuIGFsbCAmJiBcCmdpdCBjbG9uZSAgaHR0cHM6Ly9naXQua2VybmVs Lm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvd2ZnL3ZtLXNjYWxhYmlsaXR5LmdpdC8g JiYgXApjZCB2bS1zY2FsYWJpbGl0eSAmJiBtYWtlIHVzZW1lbQoKQ09QWSByZWFkdHdpY2Uu cGF0Y2ggL3ZtLXNjYWxhYmlsaXR5LwoKUlVOIGNkIHZtLXNjYWxhYmlsaXR5ICYmIHBhdGNo IC1wMSA8IHJlYWR0d2ljZS5wYXRjaAo= --------------7C4509CD50BDF422F0129A10 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="readtwice.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="readtwice.patch" ZGlmZiAtLWdpdCBhL2Nhc2UtbHJ1LWZpbGUtcmVhZHR3aWNlIGIvY2FzZS1scnUtZmlsZS1y ZWFkdHdpY2UKaW5kZXggODU1MzNiMjQ4NjM0Li41N2NiOTdkMTIxYWUgMTAwNzU1Ci0tLSBh L2Nhc2UtbHJ1LWZpbGUtcmVhZHR3aWNlCisrKyBiL2Nhc2UtbHJ1LWZpbGUtcmVhZHR3aWNl CkBAIC0xNSwyMyArMTUsMzAgQEAKIAogLiAuL2h3X3ZhcnMKIAotZm9yIGkgaW4gYHNlcSAx ICRucl90YXNrYAotZG8KLQljcmVhdGVfc3BhcnNlX2ZpbGUgJFNQQVJTRV9GSUxFLSRpICQo KFJPVEFURV9CWVRFUyAvIG5yX3Rhc2spKQotCXRpbWVvdXQgLS1mb3JlZ3JvdW5kIC1zIElO VCAke3J1bnRpbWU6LTYwMH0gZGQgYnM9NGsgaWY9JFNQQVJTRV9GSUxFLSRpIG9mPS9kZXYv bnVsbCA+ICRUTVBGU19NTlQvZGQtb3V0cHV0LTEtJGkgMj4mMSAmCi0JdGltZW91dCAtLWZv cmVncm91bmQgLXMgSU5UICR7cnVudGltZTotNjAwfSBkZCBicz00ayBpZj0kU1BBUlNFX0ZJ TEUtJGkgb2Y9L2Rldi9udWxsID4gJFRNUEZTX01OVC9kZC1vdXRwdXQtMi0kaSAyPiYxICYK LWRvbmUKK09VVF9ESVI9JChob3N0bmFtZSktJHtucl90YXNrfWMtJCgoKG1lbSArICgxPDwy OSkpPj4zMCkpZworVEVTVF9DQVNFUz0ke0A6LSQoZWNobyBjYXNlLSopfQorCitlY2hvICQo KDE8PDMwKSkgPiAvcHJvYy9zeXMvdm0vbWF4X21hcF9jb3VudAorZWNobyAkKCgxPDwyMCkp ID4gL3Byb2Mvc3lzL2tlcm5lbC90aHJlYWRzLW1heAorZWNobyAxID4gL3Byb2Mvc3lzL3Zt L292ZXJjb21taXRfbWVtb3J5CisjZWNobyAzID4gL3Byb2Mvc3lzL3ZtL2Ryb3BfY2FjaGVz CisKKworaT0xCisKK2lmIFsgIiQxIiA9PSAibSIgXTt0aGVuCisJbW91bnRfdG1wZnMKKwlj cmVhdGVfc3BhcnNlX3Jvb3QKKwljcmVhdGVfc3BhcnNlX2ZpbGUgJFNQQVJTRV9GSUxFLSRp ICQoKFJPVEFURV9CWVRFUykpCisJZXhpdAorZmkKKworCitpZiBbICIkMSIgPT0gInIiIF07 dGhlbgorCSh0aW1lb3V0IC0tZm9yZWdyb3VuZCAtcyBJTlQgJHtydW50aW1lOi0zMDB9IGRk IGJzPTRrIGlmPSRTUEFSU0VfRklMRS0kaSBvZj0vZGV2L251bGwgPiAkVE1QRlNfTU5UL2Rk LW91dHB1dC0xLSRpIDI+JjEpJgorCSh0aW1lb3V0IC0tZm9yZWdyb3VuZCAtcyBJTlQgJHty dW50aW1lOi0zMDB9IGRkIGJzPTRrIGlmPSRTUEFSU0VfRklMRS0kaSBvZj0vZGV2L251bGwg PiAkVE1QRlNfTU5UL2RkLW91dHB1dC0yLSRpIDI+JjEpJgorZmkKIAogd2FpdAogc2xlZXAg MQogCi1mb3IgZmlsZSBpbiAkVE1QRlNfTU5UL2RkLW91dHB1dC0qCi1kbwotCVsgLXMgIiRm aWxlIiBdIHx8IHsKLQkJZWNobyAiZGQgb3V0cHV0IGZpbGUgZW1wdHk6ICRmaWxlIiA+JjIK LQl9Ci0JY2F0ICRmaWxlCi0Jcm0gICRmaWxlCi1kb25lCi0KLXJtIGBzZXEgLWYgJFNQQVJT RV9GSUxFLSVnIDEgJG5yX3Rhc2tgCmRpZmYgLS1naXQgYS9od192YXJzIGIvaHdfdmFycwpp bmRleCA4NzMxY2VmYjlmNTcuLmNlZWFhOWYxN2MwYiAxMDA3NTUKLS0tIGEvaHdfdmFycwor KysgYi9od192YXJzCkBAIC0xLDQgKzEsNCBAQAotIyEvYmluL3NoCisjIS9iaW4vc2ggLWV4 CiAKIGlmIFsgLW4gIiRydW50aW1lIiBdOyB0aGVuCiAJVVNFTUVNPSIkQ01EIC4vdXNlbWVt IC0tcnVudGltZSAkcnVudGltZSIKQEAgLTQzLDcgKzQzLDcgQEAgY3JlYXRlX2xvb3BfZGV2 aWNlcygpCiAJbW9kcHJvYmUgbG9vcCAyPi9kZXYvbnVsbAogCVsgLWUgIi9kZXYvbG9vcDAi IF0gfHwgbW9kcHJvYmUgbG9vcCAyPi9kZXYvbnVsbAogCi0JZm9yIGkgaW4gJChzZXEgMCA4 KQorCWZvciBpIGluICQoc2VxIDAgMTA0KQogCWRvCiAJCVsgLWUgIi9kZXYvbG9vcCRpIiBd ICYmIGNvbnRpbnVlCiAJCW1rbm9kIC9kZXYvbG9vcCRpIGIgNyAkaQpAQCAtMTAxLDExICsx MDEsMTEgQEAgcmVtb3ZlX3NwYXJzZV9yb290ICgpIHsKIGNyZWF0ZV9zcGFyc2VfZmlsZSAo KSB7CiAJbmFtZT0kMQogCXNpemU9JDIKLQkjIGVjaG8gIiRuYW1lIGlzIG9mIHNpemUgJHNp emUiCisJZWNobyAiJG5hbWUgaXMgb2Ygc2l6ZSAkc2l6ZSIKIAkkQ01EIHRydW5jYXRlICRu YW1lIC1zICRzaXplCiAJIyBkZCBpZj0vZGV2L3plcm8gb2Y9JG5hbWUgYnM9MWsgY291bnQ9 MSBzZWVrPSQoKHNpemUgPj4gMTApKSAyPi9kZXYvbnVsbAotCSMgbHMgJFNQQVJTRV9ST09U Ci0JIyBscyAvdG1wL3ZtLXNjYWxhYmlsaXR5LyoKKwlscyAkU1BBUlNFX1JPT1QKKwlscyAv dG1wL3ZtLXNjYWxhYmlsaXR5LyoKIH0KIAogCgo= --------------7C4509CD50BDF422F0129A10--