From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C4EC432BE for ; Tue, 3 Aug 2021 15:44:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D129760FA0 for ; Tue, 3 Aug 2021 15:44:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D129760FA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 432C38D0002; Tue, 3 Aug 2021 11:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E1F68D0001; Tue, 3 Aug 2021 11:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D0E48D0002; Tue, 3 Aug 2021 11:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 136498D0001 for ; Tue, 3 Aug 2021 11:44:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C0C898249980 for ; Tue, 3 Aug 2021 15:44:57 +0000 (UTC) X-FDA: 78434192634.17.E5EF7BE Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf25.hostedemail.com (Postfix) with ESMTP id 0F7FCB0053CB for ; Tue, 3 Aug 2021 15:44:54 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UhtcbfK_1628005489; Received: from 30.39.225.192(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0UhtcbfK_1628005489) by smtp.aliyun-inc.com(127.0.0.1); Tue, 03 Aug 2021 23:44:50 +0800 Subject: Re: [PATCH] mm: memcontrol: Set the correct memcg swappiness restriction To: Vlastimil Babka , Michal Hocko Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6e6570d2-44a2-1da1-6c2a-38766786c40c@suse.cz> From: Baolin Wang Message-ID: <02826fde-43a8-e20d-37f5-55416ba0c773@linux.alibaba.com> Date: Tue, 3 Aug 2021 23:45:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <6e6570d2-44a2-1da1-6c2a-38766786c40c@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.44 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0F7FCB0053CB X-Stat-Signature: 6cccn8o93gh4ozpwo3m7hehztc6mhfp3 X-HE-Tag: 1628005494-545380 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/8/3 23:20, Vlastimil Babka wrote: > On 7/30/21 8:39 AM, Michal Hocko wrote: >> On Fri 30-07-21 14:26:35, Baolin Wang wrote: >>> Since commit c843966c556d ("mm: allow swappiness that prefers reclaiming >>> anon over the file workingset") has expended the swappiness value to >>> make swap to be preferred in some systems. We should also change the >>> memcg swappiness restriction to allow memcg swap-preferred. >>> >>> Signed-off-by: Baolin Wang >> >> Yes, this looks like an omission. It doesn't really make sense to have >> two different constrains on the value. >> >> Acked-by: Michal Hocko > > So, also Fixes: c843966c556d ("mm: allow swappiness that prefers reclaiming anon > over the file workingset") > ? Sure. Andrew, do I need resend it with adding fixes tag, or you can help to add it? Thanks.