From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E422C7EE23 for ; Wed, 17 May 2023 06:23:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F193900004; Wed, 17 May 2023 02:23:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A1C1900003; Wed, 17 May 2023 02:23:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26A75900004; Wed, 17 May 2023 02:23:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 191A2900003 for ; Wed, 17 May 2023 02:23:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DB8E21A045B for ; Wed, 17 May 2023 06:23:22 +0000 (UTC) X-FDA: 80798755044.02.21DA1B9 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 0565340002 for ; Wed, 17 May 2023 06:23:20 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mYqdXP8J; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684304601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NS9MMOeGbk46KEukFDZfhL0rwBxUJBfRVrmkoFj2ZF4=; b=dJzJQR3VQyHg/TRUbuu4aeYxP/q26nNgJUlpXI2guB+KqS8LXINqFEelK0G+9iV+m694jN 5bnkG4B4E/EKtHTqoy4ZvZWU4bptLT6yIyEMkcS3OfxOxl6wgfTbNwuRUVwWPC/1wbKKhF 5I5o3hIo7LPfcS6Dc3zAm8yzyEQuAoc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mYqdXP8J; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684304601; a=rsa-sha256; cv=none; b=qnyPjTeWrt4Q1JO6gfD4+OWodXi6IUFty3PwKcXFuedVulLR9mdZrzdoJbKfpzAziV7lU1 qynT5o/24N4jBalhO2/TJUWSkkJnHoR4ua7Cq9f1yWXAFRMBbzfB2vkJKgxugZTazywcLv 6omEx59wAWT1A6wPeSCkTemY8VA3oJ4= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3f423ac6e2dso2086865e9.2 for ; Tue, 16 May 2023 23:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684304599; x=1686896599; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NS9MMOeGbk46KEukFDZfhL0rwBxUJBfRVrmkoFj2ZF4=; b=mYqdXP8J9kEaCTfDD7GUZxQFJSqPwzz7ecfonARTNk9LHk+2ba7eNClMd/ujaR/Tmd uN48x9UpqckKUkZNW0R6kAwhFM641KB2yHZa6D1y9pEkB9SA26CNDs7GTe3Ji6xLSGk9 eVAyjTB9gFYh3chvTv5RMRtZmMg3jdooU5jvMfRX37U7ExSNgwCranU/+J7UFmB2USj6 9yzjSKj/W3bp35pX6hrizwjftEpvnt4HhUc7aEy9k0YCHgopRqhgeQxEIzn/bZnjdXxK yGHSyXGT2oAOwUgNnGwdPusK5EYBDPIfXSfA7NL3wjveDEP1+AgLOPbjDk7KdETbJ7ZH kfQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684304599; x=1686896599; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NS9MMOeGbk46KEukFDZfhL0rwBxUJBfRVrmkoFj2ZF4=; b=L/NvfeTAwHNlHfveNr7LCXWlEd49iu1q3Q8vXwDGN06x2mIWm9XwOlRs3yeY6o9fOp fDQVD3YjMjnag2lLqMcsrFXjhcQ9tMmrXEob59KMPiN299ZnnFBdZbpnxKfF7vjRyAJ7 xjzn2Ldwg6a7OxRFn7IQIdbFLPA+3RtUXqMyIUo+bJN+Gk3mAKGEz4+/RrpHWJcquWf8 bC/afH0W5KrUC66FRZjW/ncKJ49KfWCpE3wtyhrDecHNcpL5mzVUaaIicEsIKqWW/Xmt LOJrpB6WcCawXxONQgqbtaTqEcEIc1JWwvh5v12j5pHBlaHX6/P1XBe+5oaZuIgoMqOK VcVg== X-Gm-Message-State: AC+VfDwwdlNzx36xet65YRF65NkhbYHjNKWq1tOV8M/lzaCQkgaJV8tX PKDmF42ZduCx0tIIX2qxMwU= X-Google-Smtp-Source: ACHHUZ7r5LzCQMVpC3FGu3ITQsbJLJoRLsPva50TRn0LrydoALbhAoruaWc9q873rKtnnkgWSQUN2w== X-Received: by 2002:adf:dd91:0:b0:2dd:11b8:8aa9 with SMTP id x17-20020adfdd91000000b002dd11b88aa9mr29020622wrl.15.1684304599232; Tue, 16 May 2023 23:23:19 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id j11-20020adff54b000000b003062c609115sm1643188wrp.21.2023.05.16.23.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 23:23:18 -0700 (PDT) Date: Wed, 17 May 2023 07:23:17 +0100 From: Lorenzo Stoakes To: Christoph Hellwig Cc: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , SeongJae Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev, Uladzislau Rezki Subject: Re: [RESEND PATCH v1 1/5] mm: vmalloc must set pte via arch code Message-ID: <029289f2-1300-422a-8771-1d6b83470aad@lucifer.local> References: <20230511132113.80196-1-ryan.roberts@arm.com> <20230511132113.80196-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0565340002 X-Stat-Signature: ckbo68ix8kdgzbwi5q74psj855s91iqo X-HE-Tag: 1684304600-278883 X-HE-Meta: U2FsdGVkX18j4uJ7ZEduJIbbTljpXlZXh9d26AF/nFfiedmq04AIotI4Tht0f1m6vrnfXAmrzXZYy6ddnVA9v/iKi52IAjh/dVZTyW4aL+u552rx9DvvHtTRGqdv/IpyRUWyk8mwVIEClSeYtqp++62eUpRNeWf6IeI+ljbLzf46sS0I+IlMslZiuWQrvDnx3fyz8mFIUh9Vd/SIONXwlYJYJf8dVUuBUItxx+gIPNt5RjI9E5NwNZoiYhi5mY7Azmz7G5FEqYxQ6fjIFUT4TfVK4upb6wGJCeQdBxWkwNCShn4viQJCCjYS94nXCldkHGHPORbVm2FIpNd9Ygr0ZjUB0nPvIqNBKlI8yvL7Wyagl4njC2YgSldZLehxJwUWsivAWjMZEWBQVfZNISi3kXO0SvInUN8uAyqczC8tok96qbrM5JY3QTvXoTK5GxnAm7OSL2Zyx7q4zYe/9D5wMDXK1Jb4y89mi93/SE2KE2MsRFx0iMcJOeH16VZWBAS0Z7g9knzpRg0OsXM3rEYjaoMrmKvzQ2vvELZvzKyIRraxtzNkTUdSeyot2kWC+8LCcCCza7N1f4n8tNeeTFNb4lRl07YxXPreB/YYa3s454MaZ51zdrWTFY7Ecu8aSXlPq76MYwkmiIiMCD1ZU9ZQry7NuqW82H9ftK8cR7sBClnzyM2WZ92XzJM3fdat6GzYMuWczileTTLY+ctREaQEK462D0gAhrHG44uLMXHPmyW+RWfFTk3p/1zQfkoPYIbP8Uvy5dgC/i/dTkkNAGQJwf761gpWB9YF4TtRBAaETrI2xwhOH2nkQ6o1WFtk9Kl8kqnK2iz+ofVvN+bsrWZZ708xZi9OTV1awIbErRjxVzylOypviechib5VW+WE/a7Xh3/G9BFDx9AV7H/WPak8dQwC5dezd5g8vQ31EeuRIpux34biPC9VAzQv4QBWSNpB0GCEteDVIuJSSzcnBCA 9Azjln3Y GWENu6B5ohbJxQsJ92tzeOwcnSHIJvTm0ByY82IWVagpdKA+bW2amFCOA0BUQKbfeElWQUAxYs8fkkhcmgXyyl2O+2x5DLUOzDbzIwdk4lLhTIAAtOexpAQiQQkx+8v0g8r15Hp2IMp8aqvi5+FJnNb4v1PJTDXCjI6oUteo9HMk885FjoZAssAkl6jUGGlgEcTy+aL6Gk70WrdDKiifmi7+iA6lLX638BQ8jMSMrjBNJeZms52HI5iLYAWGv9f4JI/C6Lfzu+5sniA70bv0HpJKZ8Xe3luvwLJOHbTJS51XBghXImO6hOMUP12dbC9rk5SD4MA+uAuCKSgailJOaw7PzhMiRga/uHJ2PvwZjLUDHA4DRZI0pNvtFWQEHQbPNBxXlmq1et05Rkxr8j3YIsolNUJ2dizLPrAYZNdrYiG1Sac8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 11:20:07PM -0700, Christoph Hellwig wrote: > On Sat, May 13, 2023 at 02:14:18PM +0100, Lorenzo Stoakes wrote: > > > Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") > > > > Not sure if this is really 'fixing' anything, I mean ostensibly, but not > > sure if the tag is relevant here, that is more so for a bug being > > introduced, and unless an issue has arisen not sure if it's > > appropriate. But this might be a nit, again! > > vmap_pfn was factored out of i915-specific code, which probably never > ran on anything but x86 at that time. Now that intel builds plug in > GPUs is probably could. But independent of that core mm code should use > the proper APIs. > Yeah indeed, I just wondered if the tag was quite right for this but it's not a big deal, fine to leave in. I agree the approach is correct, just wanted your ok so also adding my:- Acked-by: Lorenzo Stoakes