From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2927CC432BE for ; Mon, 9 Aug 2021 13:35:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9848761058 for ; Mon, 9 Aug 2021 13:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9848761058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EEB418D0001; Mon, 9 Aug 2021 09:35:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9B9A6B0071; Mon, 9 Aug 2021 09:35:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D89A08D0001; Mon, 9 Aug 2021 09:35:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id BC5FC6B006C for ; Mon, 9 Aug 2021 09:35:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6D6DD180AD5C5 for ; Mon, 9 Aug 2021 13:35:04 +0000 (UTC) X-FDA: 78455638128.24.AFC327B Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf01.hostedemail.com (Postfix) with ESMTP id 6EA8C5021EDE for ; Mon, 9 Aug 2021 13:35:03 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Gjxs204Ybz1CTxx; Mon, 9 Aug 2021 21:34:46 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 9 Aug 2021 21:34:58 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 9 Aug 2021 21:34:57 +0800 Subject: Re: [PATCH v3 3/3] kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC To: Marco Elver CC: , , , , , , , , References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <20210809093750.131091-4-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: <03828e22-9869-7c57-3ad0-f266a435e427@huawei.com> Date: Mon, 9 Aug 2021 21:34:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Stat-Signature: 9u681qfe5zjinb1fhnwt6w55w49f3y6a X-Rspamd-Queue-Id: 6EA8C5021EDE X-Rspamd-Server: rspam01 X-HE-Tag: 1628516103-556178 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/8/9 19:21, Marco Elver wrote: > On Mon, 9 Aug 2021 at 13:10, Kefeng Wang w= rote: >> >> On 2021/8/9 17:37, Kefeng Wang wrote: >>> With KASAN_VMALLOC and NEED_PER_CPU_PAGE_FIRST_CHUNK, it crashs, >>> >>> Unable to handle kernel paging request at virtual address ffff7000028= f2000 >>> ... >>> swapper pgtable: 64k pages, 48-bit VAs, pgdp=3D0000000042440000 >>> [ffff7000028f2000] pgd=3D000000063e7c0003, p4d=3D000000063e7c0003, pu= d=3D000000063e7c0003, pmd=3D000000063e7b0003, pte=3D0000000000000000 >>> Internal error: Oops: 96000007 [#1] PREEMPT SMP >>> Modules linked in: >>> CPU: 0 PID: 0 Comm: swapper Not tainted 5.13.0-rc4-00003-gc6e6e28f3f3= 0-dirty #62 >>> Hardware name: linux,dummy-virt (DT) >>> pstate: 200000c5 (nzCv daIF -PAN -UAO -TCO BTYPE=3D--) >>> pc : kasan_check_range+0x90/0x1a0 >>> lr : memcpy+0x88/0xf4 >>> sp : ffff80001378fe20 >>> ... >>> Call trace: >>> kasan_check_range+0x90/0x1a0 >>> pcpu_page_first_chunk+0x3f0/0x568 >>> setup_per_cpu_areas+0xb8/0x184 >>> start_kernel+0x8c/0x328 >>> >>> The vm area used in vm_area_register_early() has no kasan shadow memo= ry, >>> Let's add a new kasan_populate_early_vm_area_shadow() function to pop= ulate >>> the vm area shadow memory to fix the issue. >> Should add Acked-by: Marco Elver [for KASAN parts] = , > My Ack is still valid, thanks for noting. Thanks,=C2=A0 Marco ;)