From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Henry Burns <henryburns@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/z3fold.c: fix lock/unlock imbalance in z3fold_page_isolate
Date: Thu, 29 Aug 2019 14:14:40 -0500 [thread overview]
Message-ID: <051d8e3b-b705-d34b-3193-550bef3b5c65@embeddedor.com> (raw)
In-Reply-To: <20190826160515.446dabc587706fc80e5c6e6b@linux-foundation.org>
On 8/26/19 6:05 PM, Andrew Morton wrote:
>
>
> This is a bit silly:
>
> if (..) {
> ...
> z3fold_page_unlock(zhdr);
> return false;
> }
> z3fold_page_unlock(zhdr);
> return false;
>
> but presumably the compiler will clean up after us.
>
I agree. I just sent a patch for that:
https://lore.kernel.org/lkml/20190829191312.GA20298@embeddedor/
Thanks
--
Gustavo
prev parent reply other threads:[~2019-08-29 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 3:06 [PATCH] mm/z3fold.c: fix lock/unlock imbalance in z3fold_page_isolate Gustavo A. R. Silva
2019-08-26 23:05 ` Andrew Morton
2019-08-29 19:14 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=051d8e3b-b705-d34b-3193-550bef3b5c65@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=akpm@linux-foundation.org \
--cc=henryburns@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).