From: Ralph Campbell <rcampbell@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Mike Kravetz" <mike.kravetz@oracle.com>
Subject: Re: [PATCH] mm/hmm: Fix bad subpage pointer in try_to_unmap_one
Date: Tue, 9 Jul 2019 18:24:57 -0700 [thread overview]
Message-ID: <05fffcad-cf5e-8f0c-f0c7-6ffbd2b10c2e@nvidia.com> (raw)
In-Reply-To: <20190709172823.9413bb2333363f7e33a471a0@linux-foundation.org>
On 7/9/19 5:28 PM, Andrew Morton wrote:
> On Tue, 9 Jul 2019 15:35:56 -0700 Ralph Campbell <rcampbell@nvidia.com> wrote:
>
>> When migrating a ZONE device private page from device memory to system
>> memory, the subpage pointer is initialized from a swap pte which computes
>> an invalid page pointer. A kernel panic results such as:
>>
>> BUG: unable to handle page fault for address: ffffea1fffffffc8
>>
>> Initialize subpage correctly before calling page_remove_rmap().
>
> I think this is
>
> Fixes: a5430dda8a3a1c ("mm/migrate: support un-addressable ZONE_DEVICE page in migration")
> Cc: stable
>
> yes?
>
Yes. Can you add this or should I send a v2?
next prev parent reply other threads:[~2019-07-10 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 22:35 [PATCH] mm/hmm: Fix bad subpage pointer in try_to_unmap_one Ralph Campbell
2019-07-10 0:28 ` Andrew Morton
2019-07-10 1:24 ` Ralph Campbell [this message]
2019-07-15 22:00 ` Andrew Morton
2019-07-15 23:34 ` John Hubbard
2019-07-16 0:38 ` Ralph Campbell
2019-07-16 6:14 ` John Hubbard
2019-07-16 15:33 ` Jerome Glisse
2019-07-16 21:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05fffcad-cf5e-8f0c-f0c7-6ffbd2b10c2e@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).