From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFE8C433F5 for ; Fri, 28 Jan 2022 11:13:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 206B16B0071; Fri, 28 Jan 2022 06:13:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B6A66B0072; Fri, 28 Jan 2022 06:13:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 080126B0073; Fri, 28 Jan 2022 06:13:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id E9DE66B0071 for ; Fri, 28 Jan 2022 06:13:58 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AAFCC95B18 for ; Fri, 28 Jan 2022 11:13:58 +0000 (UTC) X-FDA: 79079436156.04.C921A26 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf21.hostedemail.com (Postfix) with ESMTP id 401FE1C0051 for ; Fri, 28 Jan 2022 11:13:57 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id t7so8474536ljc.10 for ; Fri, 28 Jan 2022 03:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=9F4VhxP4SHL7oJExWpXEmXdSPfoShTeHP4aiHJ97OCc=; b=TOAKTiOjd6bbG8kOtKUP13KD6Osf7b9AVq1VqEZwyN+snKDfJoaDAYAj84qVeu85gU sF32D1a+QcXq9EUG9IYWoEwkk777+/FY88LkPkKTW56wtbj5jtDzBgZv2HxKC63NVizC RY2Zk1rN5fC8ecvXxxm+KOUkqHcXrZBD7pHziRDoZo+54L+b8dh8OpqIwJ3Mza5aE6m2 /TYbI4Lmdy6QW/y1wsDi+AI6g5pEkA7Ow8lkfNdhc8bsR0slUV7KgvkdSZac6zxTuKZe QaXmPeb3a4uKSZNhoROBdWZBwKhtHbtTgaRHZxvaPFX5K/p7xIzG4JO6AliLqUEyRe27 3JtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=9F4VhxP4SHL7oJExWpXEmXdSPfoShTeHP4aiHJ97OCc=; b=v4sx9dctpLf0YS6ToJRu2jxmoydwWhDMsnv2K5VXrRwp2ZvSJKy7Xv0o+Yip8V7Lh5 6SZxGlYg34fBOoMKOyfglZXixTli9bYZsJgeEwK8E757CZAsAQSO+IF3K9qTZInBsFUN MzZvze0tHqylWgc+B+b3XTAkqElAhKjaI6zvZ+glCVvVFX0TxGoTJ1YAHAkw75IZjYyx +PbpbDJ4rj+iaJrvh2QEAYWTtAJ21eEDJaM64MfExX6FJYVzUY7z5MlBFarSWZQ8Ezl5 Zei6dbHNl3TuM0N8TY5OvwOOmNZ6+v2Tv14SF1HkaQgDrTp10VdyTzxTQ/BbFND7MsmE L3dA== X-Gm-Message-State: AOAM531SbwrAC8KD42xVEbDOczqv9nM/l0OQUO3ieQV20xCjuOBK4R2D GXD/Cas8nZWNe75uKXEaSAc= X-Google-Smtp-Source: ABdhPJw7D5wRlMIt2p7LEmvCtXl4uMKhgMbXX85L6qr2idj94F4weaSACBAteuGkKoetRSt+Jo9GxQ== X-Received: by 2002:a05:651c:984:: with SMTP id b4mr5453766ljq.235.1643368436220; Fri, 28 Jan 2022 03:13:56 -0800 (PST) Received: from [10.3.154.43] (staticline-31-183-166-172.toya.net.pl. [31.183.166.172]) by smtp.gmail.com with ESMTPSA id p16sm787665ljc.86.2022.01.28.03.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 03:13:55 -0800 (PST) Message-ID: <066fa177642ce6907df06819676cd29c0745e816.camel@gmail.com> Subject: Re: [PATCH 06/16] tools/include: Add cache.h stub From: Karolina Drobnik To: Matthew Wilcox Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Date: Fri, 28 Jan 2022 12:13:54 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 401FE1C0051 X-Stat-Signature: 55ogaoamooid5iqyiu3smw5emsomnwha Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TOAKTiOj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of karolinadrobnik@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=karolinadrobnik@gmail.com X-Rspam-User: nil X-HE-Tag: 1643368437-899820 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.083488, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2022-01-27 at 14:00 +0000, Matthew Wilcox wrote: > On Thu, Jan 27, 2022 at 02:21:24PM +0100, Karolina Drobnik wrote: > > +++ b/tools/include/linux/cache.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _TOOLS_LINUX_CACHE_H > > +#define _TOOLS_LINUX_CACHE_H > > + > > +#define L1_CACHE_SHIFT=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A05 > > +#define L1_CACHE_BYTES=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0BIT(L1_CACHE_SHIFT) > > + > > +#define SMP_CACHE_BYTES L1_CACHE_BYTES > > + > > +#endif >=20 > You've added an implicit dependency on include/vdso/bits.h which > seems > unpleasant ... I'll admit that I just tried to make checkpatch.pl happy with this change. But you're right, adding such a dependency is undesirable. I can define it as (1 << L1_CACHE_SHIFT) and ignore the warning. Is it fine to do so for tools/testing code?