From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D379FC433C1 for ; Fri, 19 Mar 2021 17:56:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 573F861986 for ; Fri, 19 Mar 2021 17:56:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 573F861986 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B7CEA6B007B; Fri, 19 Mar 2021 13:56:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2CA46B007D; Fri, 19 Mar 2021 13:56:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A65A6B007E; Fri, 19 Mar 2021 13:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 7A4C16B007B for ; Fri, 19 Mar 2021 13:56:24 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3A4582484 for ; Fri, 19 Mar 2021 17:56:24 +0000 (UTC) X-FDA: 77937378288.08.6161DFB Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf11.hostedemail.com (Postfix) with ESMTP id 2675B20007EE for ; Fri, 19 Mar 2021 17:56:14 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id z25so13029518lja.3 for ; Fri, 19 Mar 2021 10:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EN3uRBxUV6eO1T+kGUJLe9TYovHE3LSSTvhishvZdAI=; b=c+1GxprWueFENyi5K/CZts1MNjoFWJg8eQS3tOBmbBISXM0M/JelqTmfQUv8lPyCUW XiswpSTRG6ELr/fdzcZ424IoINC0GuPR6SfL3Moby6GVLSXPvNdJzQk1Oob3tjzjTg2L HDT3gqB7gupOd0yaZtsMP+0wxcE1xpHGmS7ya7hhpI3s3Sj3NBIKgjjpkADq10BWruzv OaC+UV/CHIBV2GFJA8QQaKUG4JUiy1geLpHIVDYe9mWWtS8q8Doj6vwhZDKb4v2UTxt/ 9enabFoP27vZEiILngtyCXA4nK52I6+oAhW2tHBNk/tzR205zZanwCHolFibW14G7wNR Oq7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EN3uRBxUV6eO1T+kGUJLe9TYovHE3LSSTvhishvZdAI=; b=plFwbn97bJQb81NoTZMbnQqwEIjuF63QAKUZhW3HUBZxBcYoMbuKcSgrmWtOuTYM2u cDk/uG5Gglu3AS9fWryrj83CZyjjcJHPDHKBu4fu+vvfcfHSycDA+zGsIZfsKqDO8+3+ USQcBk7yijmFpP5gmclVmHBMF14eR2JIhIj2elEgNi4pOT9jk7LsqyMxC5cuA93mP9u6 fv5q2xUv0cUtTxrcc9+smfmE/rmKitXfPIYi+1kBuMvWeIjnRm+wjgFIeCJGBW9yhlHL zm85WHU3caOJjW5Fh/642we7jZdNLUAdsl1y8GpZd9m3NG0/rPL21997slwGo9alRLr1 BJKA== X-Gm-Message-State: AOAM5309E9x+5dpR28BztGtH4kgKUuoMTaWcIOuWOJfShdra1KaI94Z+ bwwtX0JlZWUl3xW1cLcnwhM= X-Google-Smtp-Source: ABdhPJxq1u9oT6lgD+hfhtI3hv0grR3ARQY1SAwmD6LDpEXcJ/1QOK0n2WfApV/cYW4FNb5WkiE5sA== X-Received: by 2002:a2e:a0d0:: with SMTP id f16mr1679862ljm.215.1616176567012; Fri, 19 Mar 2021 10:56:07 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id e8sm855367ljg.22.2021.03.19.10.56.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 10:56:06 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Minchan Kim Cc: Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> From: Dmitry Osipenko Message-ID: <071c6681-f492-2c94-5686-30c30778f39d@gmail.com> Date: Fri, 19 Mar 2021 20:56:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2675B20007EE X-Stat-Signature: acpezt4udg8xisci55dryerhof478u6o Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-lj1-f181.google.com; client-ip=209.85.208.181 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616176574-553169 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 19:30, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > +static void cma_kobj_release(struct kobject *kobj) > +{ > + struct cma_kobject *cma_kobj =3D container_of(kobj, struct cma_kobjec= t, kobj); > + > + kfree(cma_kobj); > +} Oh, wait.. I think this kfree wrong since cma_kobj belongs to the array.