From: zhaogongyi <zhaogongyi@huawei.com>
To: David Hildenbrand <david@redhat.com>,
Akinobu Mita <akinobu.mita@gmail.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"osalvador@suse.de" <osalvador@suse.de>,
"shuah@kernel.org" <shuah@kernel.org>
Subject: Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values
Date: Mon, 19 Sep 2022 09:01:38 +0000 [thread overview]
Message-ID: <076b1f2a38ab4ca4a61e6a79c765bcba@huawei.com> (raw)
Hi!
>
> On 17.09.22 07:39, Akinobu Mita wrote:
> > 2022年9月15日(木) 18:01 Zhao Gongyi <zhaogongyi@huawei.com>:
> >>
> >> Fault injection uses debugfs in a way that the provided values via
> >> sysfs are interpreted as u64. Providing negative numbers results in
> >> an error:
> >>
> >> # cd sys/kernel/debug/notifier-error-inject/memory
> >> # echo -12 > actions/MEM_GOING_ONLINE/error
> >> -bash: echo: write error: Invalid argument
> >>
> >> Update the docs and examples to use "printf %#x <val>" in these cases.
> >
> > I'd rather fix the notifier-error-inject module than change the user
> interface.
> > I'll send a patch, so could you check if that solves the problem.
> >
>
> That will also make patch #2 unnecessary, correct?
Yes. But there is another commit 005747526d4f3c2ec995891e95cb7625161022f9 that has the same problem.
Thanks!
>
> --
> Thanks,
>
> David / dhildenb
next reply other threads:[~2022-09-19 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 9:01 zhaogongyi [this message]
2022-09-19 11:05 ` [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values David Hildenbrand
-- strict thread matches above, loose matches on Subject: below --
2022-09-15 8:57 [PATCH -next v2 0/5] Optimize and bugfix for notifier error Zhao Gongyi
2022-09-15 8:57 ` [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values Zhao Gongyi
2022-09-17 5:39 ` Akinobu Mita
2022-09-19 8:43 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=076b1f2a38ab4ca4a61e6a79c765bcba@huawei.com \
--to=zhaogongyi@huawei.com \
--cc=akinobu.mita@gmail.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).