From: John Hubbard <jhubbard@nvidia.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: <linux-mm@kvack.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@intel.com>,
Andrew Morton <akpm@linux-foundation.org>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] x86/mm: Make pud_present() check _PAGE_PROTNONE and _PAGE_PSE as well
Date: Fri, 20 Mar 2020 12:50:03 -0700 [thread overview]
Message-ID: <082aae4a-b190-7b54-eda9-0bbc28c8a6b3@nvidia.com> (raw)
In-Reply-To: <2e7a04cf-80cb-58c1-7344-2f8422ed7d31@arm.com>
On 3/20/20 6:22 AM, Anshuman Khandual wrote:
...
>>> +Cc: Kirill A. Shutemov <kirill@shutemov.name>
>>> +Cc: Dan Williams <dan.j.williams@intel.com>
>>
>> Or we can just drop the pud_mknotpresent(). There's no users AFAICS and
>> only x86 provides it.
+1
>
> Yes that will be an option but IMHO fixing pud_present() here might be
> a better choice because,
>
> (1) pud_mknotpresent() with fixed pud_present() might be required later
It might. Or it might not. Let's wait until it's actually used, and see.
Dead code is an avoidable expense (adds size, space on the screen, email
traffic and other wasted time), so let's avoid it here.
> (2) PMD & PUD will be exact same (THP is supported on either level)
>
> Nonetheless, I am happy to go either way.
>
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2020-03-20 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 5:01 [PATCH] x86/mm: Make pud_present() check _PAGE_PROTNONE and _PAGE_PSE as well Anshuman Khandual
2020-03-20 3:23 ` Anshuman Khandual
2020-03-20 11:47 ` Kirill A. Shutemov
2020-03-20 13:22 ` Anshuman Khandual
2020-03-20 19:50 ` John Hubbard [this message]
2020-03-22 1:00 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=082aae4a-b190-7b54-eda9-0bbc28c8a6b3@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).