From: Vlastimil Babka <vbabka@suse.cz>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: linux-mm@kvack.org, rientjes@google.com, penberg@kernel.org,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, bigeasy@linutronix.de,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: Re: [PATCH V2] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
Date: Fri, 16 Sep 2022 23:02:17 +0200 [thread overview]
Message-ID: <084d7ef4-15a8-1d4e-6b20-5a848102ac03@suse.cz> (raw)
In-Reply-To: <20220912161140.34281-1-mlombard@redhat.com>
On 9/12/22 18:11, Maurizio Lombardi wrote:
> @@ -2730,7 +2735,7 @@ static void flush_all_cpus_locked(struct kmem_cache *s)
> INIT_WORK(&sfw->work, flush_cpu_slab);
> sfw->skip = false;
> sfw->s = s;
> - schedule_work_on(cpu, &sfw->work);
> + queue_work_on(cpu, flushwq, &sfw->work);
> }
>
> for_each_online_cpu(cpu) {
> @@ -4858,6 +4863,8 @@ void __init kmem_cache_init(void)
>
> void __init kmem_cache_init_late(void)
> {
> + flushwq = create_workqueue("slub_flushwq");
> + BUG_ON(!flushwq);
Adding new BUG_ON is essentially prohibited these days, so please use WARN_ON().
Other than that deprecation issue, looks fine to me.
> }
>
> struct kmem_cache *
prev parent reply other threads:[~2022-09-16 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 16:11 [PATCH V2] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context Maurizio Lombardi
2022-09-15 12:47 ` Hyeonggon Yoo
2022-09-16 7:27 ` Maurizio Lombardi
2022-09-16 21:02 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=084d7ef4-15a8-1d4e-6b20-5a848102ac03@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mlombard@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).