Re: [kbuild-all] Re: [mmotm:master 236/260] sdhci-of-aspeed.c:undefined reference to `of_platform_device_create'

From: Rong Chen <rong.a.chen@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	kbuild test robot <lkp@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Lu Shuaibing <shuaibinglu@126.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [kbuild-all] Re: [mmotm:master 236/260] sdhci-of-aspeed.c:undefined reference to `of_platform_device_create'
Date: Wed, 9 Oct 2019 14:37:23 +0800	[thread overview]
Message-ID: <0972fee3-c9a7-b76a-90d2-55cc6622d6b7@intel.com> (raw)
In-Reply-To: <83b55462-4da3-f420-8e01-0188cfd985f0@infradead.org>

On 10/1/19 7:28 AM, Randy Dunlap wrote:
> On 9/29/19 12:35 AM, kbuild test robot wrote:
>> Hi Andrew,
>>
>> It's probably a bug fix that unveils the link errors.
>>
>> tree:   git://git.cmpxchg.org/linux-mmotm.git master
>> head:   89331b857195aa00660fb19f1383924e95f7709e
>> commit: d9cc9c2bd830a180cc8ac762a739fcfd3fc6c330 [236/260] linux-next-git-rejects
>> config: sparc-allyesconfig (attached as .config)
>> compiler: sparc64-linux-gcc (GCC) 7.4.0
>> reproduce:
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          git checkout d9cc9c2bd830a180cc8ac762a739fcfd3fc6c330
>>          # save the attached .config to linux build tree
>>          GCC_VERSION=7.4.0 make.cross ARCH=sparc
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>>     `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>>     `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>>     `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
>>     drivers/mmc/host/sdhci-of-aspeed.o: In function `aspeed_sdc_probe':
>>>> sdhci-of-aspeed.c:(.text+0xf8): undefined reference to `of_platform_device_create'
> I don't see how this last build error could happen with
> mmotm-2019-09-25-18-10 (latest ATM) since it contains this patch:
>
> commit 72976643aef55a2a3eec85e5342a3c3608f66e64
> Author: Andrew Jeffery <andrew@aj.id.au>
> Date:   Wed Sep 4 11:51:20 2019 +0930
>
>      mmc: sdhci-of-aspeed: Depend on CONFIG_OF_ADDRESS
>      
>      Resolves the following build error reported by the 0-day bot:
>      
>          ERROR: "of_platform_device_create" [drivers/mmc/host/sdhci-of-aspeed.ko] undefined!
>      
>      SPARC does not set CONFIG_OF_ADDRESS so the symbol is missing. Depend on
>      CONFIG_OF_ADDRESS to ensure the driver is only built for supported
>      configurations.
>      
>      Fixes: 2d28dbe042f4 ("mmc: sdhci-of-aspeed: Add support for the ASPEED SD controller")
>      Reported-by: kbuild test robot <lkp@intel.com>
>      Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>      Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
>
> I cannot reproduce this problem with mmotm latest.
>

Thanks for the explanation, the master branch doesn't contain the fix 
patch, so the bot reported it.

Best Regards,
Rong Chen