From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B488FC47404 for ; Wed, 9 Oct 2019 06:37:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 79BCB20B7C for ; Wed, 9 Oct 2019 06:37:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79BCB20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1FAE98E0005; Wed, 9 Oct 2019 02:37:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AB488E0003; Wed, 9 Oct 2019 02:37:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C1CE8E0005; Wed, 9 Oct 2019 02:37:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id DA4D48E0003 for ; Wed, 9 Oct 2019 02:37:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id BEC193A9B for ; Wed, 9 Oct 2019 06:37:44 +0000 (UTC) X-FDA: 76023290448.17.trail53_94f4a6ef9d30 X-HE-Tag: trail53_94f4a6ef9d30 X-Filterd-Recvd-Size: 4486 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Oct 2019 06:37:43 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 23:37:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,273,1566889200"; d="scan'208";a="277335762" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.6]) ([10.239.13.6]) by orsmga001.jf.intel.com with ESMTP; 08 Oct 2019 23:37:39 -0700 Subject: Re: [kbuild-all] Re: [mmotm:master 236/260] sdhci-of-aspeed.c:undefined reference to `of_platform_device_create' To: Randy Dunlap , kbuild test robot , Andrew Morton Cc: kbuild-all@01.org, Linux Memory Management List , Lu Shuaibing , Johannes Weiner References: <201909291514.GrECszJZ%lkp@intel.com> <83b55462-4da3-f420-8e01-0188cfd985f0@infradead.org> From: Rong Chen Message-ID: <0972fee3-c9a7-b76a-90d2-55cc6622d6b7@intel.com> Date: Wed, 9 Oct 2019 14:37:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <83b55462-4da3-f420-8e01-0188cfd985f0@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/1/19 7:28 AM, Randy Dunlap wrote: > On 9/29/19 12:35 AM, kbuild test robot wrote: >> Hi Andrew, >> >> It's probably a bug fix that unveils the link errors. >> >> tree: git://git.cmpxchg.org/linux-mmotm.git master >> head: 89331b857195aa00660fb19f1383924e95f7709e >> commit: d9cc9c2bd830a180cc8ac762a739fcfd3fc6c330 [236/260] linux-next-git-rejects >> config: sparc-allyesconfig (attached as .config) >> compiler: sparc64-linux-gcc (GCC) 7.4.0 >> reproduce: >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> git checkout d9cc9c2bd830a180cc8ac762a739fcfd3fc6c330 >> # save the attached .config to linux build tree >> GCC_VERSION=7.4.0 make.cross ARCH=sparc >> >> If you fix the issue, kindly add following tag >> Reported-by: kbuild test robot >> >> All errors (new ones prefixed by >>): >> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o >> drivers/mmc/host/sdhci-of-aspeed.o: In function `aspeed_sdc_probe': >>>> sdhci-of-aspeed.c:(.text+0xf8): undefined reference to `of_platform_device_create' > I don't see how this last build error could happen with > mmotm-2019-09-25-18-10 (latest ATM) since it contains this patch: > > commit 72976643aef55a2a3eec85e5342a3c3608f66e64 > Author: Andrew Jeffery > Date: Wed Sep 4 11:51:20 2019 +0930 > > mmc: sdhci-of-aspeed: Depend on CONFIG_OF_ADDRESS > > Resolves the following build error reported by the 0-day bot: > > ERROR: "of_platform_device_create" [drivers/mmc/host/sdhci-of-aspeed.ko] undefined! > > SPARC does not set CONFIG_OF_ADDRESS so the symbol is missing. Depend on > CONFIG_OF_ADDRESS to ensure the driver is only built for supported > configurations. > > Fixes: 2d28dbe042f4 ("mmc: sdhci-of-aspeed: Add support for the ASPEED SD controller") > Reported-by: kbuild test robot > Signed-off-by: Andrew Jeffery > Signed-off-by: Ulf Hansson > > > I cannot reproduce this problem with mmotm latest. > Thanks for the explanation, the master branch doesn't contain the fix patch, so the bot reported it. Best Regards, Rong Chen