From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AA3C388F7 for ; Fri, 13 Nov 2020 12:01:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8DCC82224C for ; Fri, 13 Nov 2020 12:01:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DCC82224C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D41C6B00D6; Fri, 13 Nov 2020 07:01:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05DE06B00D8; Fri, 13 Nov 2020 07:01:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E684D6B00D9; Fri, 13 Nov 2020 07:01:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id B30D36B00D6 for ; Fri, 13 Nov 2020 07:01:47 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 57BB61EE6 for ; Fri, 13 Nov 2020 12:01:47 +0000 (UTC) X-FDA: 77479255854.12.men77_56125492730e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 3596418056267 for ; Fri, 13 Nov 2020 12:01:47 +0000 (UTC) X-HE-Tag: men77_56125492730e X-Filterd-Recvd-Size: 3019 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 12:01:46 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D440C142F; Fri, 13 Nov 2020 04:01:45 -0800 (PST) Received: from [10.37.12.45] (unknown [10.37.12.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4BE93F6CF; Fri, 13 Nov 2020 04:01:42 -0800 (PST) Subject: Re: [PATCH v9 30/44] arm64: kasan: Allow enabling in-kernel MTE To: Catalin Marinas Cc: Andrey Konovalov , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5ce2fc45920e59623a4a9d8d39b6c96792f1e055.1605046192.git.andreyknvl@google.com> <20201112094354.GF29613@gaia> <66ef4957-f399-4af1-eec5-d5782551e995@arm.com> <20201113120000.GB3212@gaia> From: Vincenzo Frascino Message-ID: <0ab166e6-9087-6d3b-fc66-ce9909721a86@arm.com> Date: Fri, 13 Nov 2020 12:04:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201113120000.GB3212@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/13/20 12:00 PM, Catalin Marinas wrote: > On Fri, Nov 13, 2020 at 11:17:15AM +0000, Vincenzo Frascino wrote: >> On 11/12/20 9:43 AM, Catalin Marinas wrote: >>> On Tue, Nov 10, 2020 at 11:10:27PM +0100, Andrey Konovalov wrote: >>>> From: Vincenzo Frascino >>>> >>>> Hardware tag-based KASAN relies on Memory Tagging Extension (MTE) >>>> feature and requires it to be enabled. MTE supports >>>> >>>> This patch adds a new mte_init_tags() helper, that enables MTE in >>>> Synchronous mode in EL1 and is intended to be called from KASAN runtime >>>> during initialization. >>> >>> There's no mte_init_tags() in this function. >> >> During the rework, I realized that the description of mte_init_tags() in this >> patch refers to mte_enable_kernel(). In fact the only thing that mte_init_tags() >> does is to configure the GCR_EL1 register, hence my preference would be to keep >> all the code that deals with such a register in one patch. > > Fine by me as long as the commit text is consistent with the diff. > Done already, it will be in the next series. Thank you for the quick turnaround. -- Regards, Vincenzo