From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Dpe1=D3=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id F1EB6C388F2
	for <linux-mm@archiver.kernel.org>; Tue, 20 Oct 2020 18:45:34 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 25CD92223C
	for <linux-mm@archiver.kernel.org>; Tue, 20 Oct 2020 18:45:33 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="ThfWWhJX"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25CD92223C
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 2FDBD6B005C; Tue, 20 Oct 2020 14:45:33 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 286646B0062; Tue, 20 Oct 2020 14:45:33 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 14E8B6B0068; Tue, 20 Oct 2020 14:45:33 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139])
	by kanga.kvack.org (Postfix) with ESMTP id D86FD6B005C
	for <linux-mm@kvack.org>; Tue, 20 Oct 2020 14:45:32 -0400 (EDT)
Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay01.hostedemail.com (Postfix) with ESMTP id 79370180AD807
	for <linux-mm@kvack.org>; Tue, 20 Oct 2020 18:45:32 +0000 (UTC)
X-FDA: 77393182104.29.show57_5f0025627241
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin29.hostedemail.com (Postfix) with ESMTP id 51659180868D9
	for <linux-mm@kvack.org>; Tue, 20 Oct 2020 18:45:32 +0000 (UTC)
X-HE-Tag: show57_5f0025627241
X-Filterd-Recvd-Size: 4600
Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64])
	by imf48.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Tue, 20 Oct 2020 18:45:31 +0000 (UTC)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
	id <B5f8f301b0000>; Tue, 20 Oct 2020 11:44:43 -0700
Received: from [10.2.55.194] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 20 Oct
 2020 18:45:30 +0000
Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h
To: Linus Torvalds <torvalds@linux-foundation.org>
CC: Matthew Wilcox <willy@infradead.org>, Andrew Morton
	<akpm@linux-foundation.org>, Jonathan Corbet <corbet@lwn.net>, Jerome Glisse
	<jglisse@redhat.com>, Linux-MM <linux-mm@kvack.org>,
	<mm-commits@vger.kernel.org>, Ralph Campbell <rcampbell@nvidia.com>, "Shuah
 Khan" <shuah@kernel.org>, Jason Gary Gunthorpe <jgg@nvidia.com>
References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org>
 <20201017231425.0OZYgQdDr%akpm@linux-foundation.org>
 <CAHk-=whKr_s380D-ZobrMCYy3HkeHEbaYnE7oR0G8W==hzQW7w@mail.gmail.com>
 <d191ed51-1e27-45af-2ba2-d60b4d7f3ba7@nvidia.com>
 <20201018190327.GN20115@casper.infradead.org>
 <9eaf122b-e877-e104-6175-13d48c13ac85@nvidia.com>
 <CAHk-=wgh-TMPHLY3jueHX7Y2fWh3D+nMBqVS__AZm6-oorquWA@mail.gmail.com>
 <59c6b448-039a-e56b-1ec6-9f92e316acb0@nvidia.com>
 <6dd0e8ea-3b86-8289-473d-3ffef99805ba@nvidia.com>
 <CAHk-=wgVXRuXY-2-EC_gTNKZV3zWJztt0AtssZOxuN5wFp+6zw@mail.gmail.com>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <0ad0147e-e3fb-0d95-7ba8-784f4667b24e@nvidia.com>
Date: Tue, 20 Oct 2020 11:45:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CAHk-=wgVXRuXY-2-EC_gTNKZV3zWJztt0AtssZOxuN5wFp+6zw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1603219483; bh=cpm5vdvad9ofSr1KDbt10zb1irc5p7Lk2A4d3ecF4B0=;
	h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
	 MIME-Version:In-Reply-To:Content-Type:Content-Language:
	 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
	b=ThfWWhJXnemMovWEvbukCiD/DMDS+oASt7ZmuSlQqni+W3IdjGK+Ly9MNMgKsPT1B
	 nKPieir19+6ep2egl7xHpOdop1eBQ8X7IJIwjQxQG1z5bdjvrBJVIf9xumYgIdm9ym
	 8vI8jzMTBbKZI+l8e7BdntQ06tFGTVQP8gqrICW5lstP6c/cNSbs8fUjA5QS8t6kLp
	 bGhfhZsWNpqvJ+tYIUqAOKysUeUYdX3J7yWXN3G5DA4195i2SSS+Ybv7oODla+u3CV
	 u78QPUIoK8kwhXZ0pHZu0vdHbt720YfOA++NXCEBDOH3DyryIcnN7ZwC1zgOe5lhtq
	 d8hXRpMeUf7ag==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 10/20/20 9:45 AM, Linus Torvalds wrote:
> On Mon, Oct 19, 2020 at 9:13 PM John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> Also, if there is anything I can do to unblock this, such as sending a formal
>> patch, or an updated patch or patchset, please let me know. I realize that
>> this is a low-priority area, but it would still be nice to get it merged
>> and behind us.
> 
> So what happens when I notice something like this, I just drop it from
> my queue, the policy being "this was clearly not ready to be sent to
> Linus".
> 
> That doesn't mean that it's blacklisted, but it does mean that I don't
> want to see it returned immediately with the superficial thing fixed
> that I noticed.
> 
> That's partly because I feel that people need to take another look and
> see if there was perhaps something else going on (if I found one small
> thing, maybe there are others lurking).
> 
> But admittedly it's probably mostly because I really don't want to
> feel like I'm the wall that people throw spaghetti at to see if it
> sticks. By the time it came to me, it was supposed to be ready (unless
> I'm actively part of the development of said feature of course - which
> still happens occasionally, but on the whole is a vanishingly small
> part of the stuff I merge).
> 
> So I do expect to see it again later in some patch submission, just
> not right now.
> 
>                   Linus

Makes perfect sense. I was wondering if it was blacklisted or in purgatory
or what, but now I get it. Thanks for explaining that part of the flow.

I'll see if I can pick up some more reviews, during this next cycle.


thanks,
-- 
John Hubbard
NVIDIA