From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4800C433E0 for ; Fri, 31 Jul 2020 23:55:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75D072054F for ; Fri, 31 Jul 2020 23:55:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75D072054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E4B4B8D0063; Fri, 31 Jul 2020 19:55:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFE7D8D000B; Fri, 31 Jul 2020 19:55:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D11D78D0063; Fri, 31 Jul 2020 19:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BAD168D000B for ; Fri, 31 Jul 2020 19:55:05 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4711B180AD802 for ; Fri, 31 Jul 2020 23:55:05 +0000 (UTC) X-FDA: 77100029370.23.laugh96_1f1571126f87 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 0B5C137606 for ; Fri, 31 Jul 2020 23:55:05 +0000 (UTC) X-HE-Tag: laugh96_1f1571126f87 X-Filterd-Recvd-Size: 5735 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jul 2020 23:55:03 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0U4Ln6pe_1596239697; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U4Ln6pe_1596239697) by smtp.aliyun-inc.com(127.0.0.1); Sat, 01 Aug 2020 07:54:59 +0800 Subject: Re: [PATCH RFC] mm: Add function for testing if the current lruvec lock is valid To: alexander.h.duyck@intel.com Cc: akpm@linux-foundation.org, alexander.duyck@gmail.com, aryabinin@virtuozzo.com, cgroups@vger.kernel.org, daniel.m.jordan@oracle.com, hannes@cmpxchg.org, hughd@google.com, iamjoonsoo.kim@lge.com, khlebnikov@yandex-team.ru, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, mgorman@techsingularity.net, richard.weiyang@gmail.com, rong.a.chen@intel.com, shakeelb@google.com, tglx@linutronix.de, tj@kernel.org, willy@infradead.org, yang.shi@linux.alibaba.com References: <1595681998-19193-19-git-send-email-alex.shi@linux.alibaba.com> <159622999150.2576729.14455020813024958573.stgit@ahduyck-desk1.jf.intel.com> From: Alex Shi Message-ID: <0c0a415a-52a0-5c06-b4be-80cbd3cb49c2@linux.alibaba.com> Date: Sat, 1 Aug 2020 07:54:48 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <159622999150.2576729.14455020813024958573.stgit@ahduyck-desk1.jf.intel.com> Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 0B5C137606 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It looks much better than mine. and could replace 'mm/lru: introduce the = relock_page_lruvec function' with your author signed. :) BTW, it's the rcu_read_lock cause the will-it-scale/page_fault3 regression whi= ch you mentained in another letter? Thanks Alex =E5=9C=A8 2020/8/1 =E4=B8=8A=E5=8D=885:14, alexander.h.duyck@intel.com =E5= =86=99=E9=81=93: > From: Alexander Duyck >=20 > When testing for relock we can avoid the need for RCU locking if we sim= ply > compare the page pgdat and memcg pointers versus those that the lruvec = is > holding. By doing this we can avoid the extra pointer walks and accesse= s of > the memory cgroup. >=20 > In addition we can avoid the checks entirely if lruvec is currently NUL= L. >=20 > Signed-off-by: Alexander Duyck > --- > include/linux/memcontrol.h | 52 +++++++++++++++++++++++++++---------= -------- > 1 file changed, 32 insertions(+), 20 deletions(-) >=20 > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 6e670f991b42..7a02f00bf3de 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -405,6 +405,22 @@ static inline struct lruvec *mem_cgroup_lruvec(str= uct mem_cgroup *memcg, > =20 > struct lruvec *mem_cgroup_page_lruvec(struct page *, struct pglist_dat= a *); > =20 > +static inline bool lruvec_holds_page_lru_lock(struct page *page, > + struct lruvec *lruvec) > +{ > + pg_data_t *pgdat =3D page_pgdat(page); > + const struct mem_cgroup *memcg; > + struct mem_cgroup_per_node *mz; > + > + if (mem_cgroup_disabled()) > + return lruvec =3D=3D &pgdat->__lruvec; > + > + mz =3D container_of(lruvec, struct mem_cgroup_per_node, lruvec); > + memcg =3D page->mem_cgroup ? : root_mem_cgroup; > + > + return lruvec->pgdat =3D=3D pgdat && mz->memcg =3D=3D memcg; > +} > + > struct mem_cgroup *mem_cgroup_from_task(struct task_struct *p); > =20 > struct mem_cgroup *get_mem_cgroup_from_mm(struct mm_struct *mm); > @@ -880,6 +896,14 @@ static inline struct lruvec *mem_cgroup_page_lruve= c(struct page *page, > return &pgdat->__lruvec; > } > =20 > +static inline bool lruvec_holds_page_lru_lock(struct page *page, > + struct lruvec *lruvec) > +{ > + pg_data_t *pgdat =3D page_pgdat(page); > + > + return lruvec =3D=3D &pgdat->__lruvec; > +} > + > static inline struct mem_cgroup *parent_mem_cgroup(struct mem_cgroup *= memcg) > { > return NULL; > @@ -1317,18 +1341,12 @@ static inline void unlock_page_lruvec_irqrestor= e(struct lruvec *lruvec, > static inline struct lruvec *relock_page_lruvec_irq(struct page *page, > struct lruvec *locked_lruvec) > { > - struct pglist_data *pgdat =3D page_pgdat(page); > - bool locked; > + if (locked_lruvec) { > + if (lruvec_holds_page_lru_lock(page, locked_lruvec)) > + return locked_lruvec; > =20 > - rcu_read_lock(); > - locked =3D mem_cgroup_page_lruvec(page, pgdat) =3D=3D locked_lruvec; > - rcu_read_unlock(); > - > - if (locked) > - return locked_lruvec; > - > - if (locked_lruvec) > unlock_page_lruvec_irq(locked_lruvec); > + } > =20 > return lock_page_lruvec_irq(page); > } > @@ -1337,18 +1355,12 @@ static inline struct lruvec *relock_page_lruvec= _irq(struct page *page, > static inline struct lruvec *relock_page_lruvec_irqsave(struct page *p= age, > struct lruvec *locked_lruvec, unsigned long *flags) > { > - struct pglist_data *pgdat =3D page_pgdat(page); > - bool locked; > - > - rcu_read_lock(); > - locked =3D mem_cgroup_page_lruvec(page, pgdat) =3D=3D locked_lruvec; > - rcu_read_unlock(); > - > - if (locked) > - return locked_lruvec; > + if (locked_lruvec) { > + if (lruvec_holds_page_lru_lock(page, locked_lruvec)) > + return locked_lruvec; > =20 > - if (locked_lruvec) > unlock_page_lruvec_irqrestore(locked_lruvec, *flags); > + } > =20 > return lock_page_lruvec_irqsave(page, flags); > } >=20