linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>,
	Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-mm@kvack.org, Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RFC] s390x/vmem: get rid of memory segment list
Date: Mon, 29 Jun 2020 14:01:22 +0200	[thread overview]
Message-ID: <0c783dbb-630c-6440-74b8-8b40af146d6a@redhat.com> (raw)
In-Reply-To: <20200629115537.GC4468@osiris>

On 29.06.20 13:55, Heiko Carstens wrote:
> On Fri, Jun 26, 2020 at 08:46:21PM +0200, Gerald Schaefer wrote:
>> Verified with DCSS overlapping boot and standby memory, works fine.
>> As expected, the error message changes, but I don't think that is a
>> problem, as long as you also remove the old -ENOSPC case / comment
>> in arch/s390/mm/extmem.c. It is actually more correct now I guess,
>> -ENOSPC doesn't look like the correct return value anyway.
>>
>> Thanks for cleaning up! Looks good to me, and removes > 100 LOC,
>> unless Heiko remembers some other issues from ancient times.
>>
>> Reviewed-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
>> Tested-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> [DCSS]
> 
> Looks good to me too. Gerald, thanks for looking and verifying this,
> and David, thanks for providing the patch.
> 
> Applied.
> 

Thanks Gerald and Heiko! Should I send an addon patch to tweak the
documentation or resend this patch?

-- 
Thanks,

David / dhildenb



  reply	other threads:[~2020-06-29 12:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 15:00 [PATCH RFC] s390x/vmem: get rid of memory segment list David Hildenbrand
2020-06-25 19:38 ` Heiko Carstens
2020-06-25 19:54   ` David Hildenbrand
2020-06-26 17:22 ` Gerald Schaefer
2020-06-26 17:26   ` Gerald Schaefer
2020-06-26 18:46   ` Gerald Schaefer
2020-06-29 11:55     ` Heiko Carstens
2020-06-29 12:01       ` David Hildenbrand [this message]
2020-06-29 12:07         ` Heiko Carstens
2020-06-30  8:42 ` [PATCH v1] s390/extmem: remove stale -ENOSPC comment and handling David Hildenbrand
2020-07-01  9:24   ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c783dbb-630c-6440-74b8-8b40af146d6a@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=borntraeger@de.ibm.com \
    --cc=gerald.schaefer@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).