linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Faiyaz Mohammed <faiyazm@codeaurora.org>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
	iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	glittao@gmail.com, vinmenon@codeaurora.org
Subject: Re: [PATCH v7] mm: slub: move sysfs slab alloc/free interfaces to debugfs
Date: Wed, 26 May 2021 17:07:56 +0200	[thread overview]
Message-ID: <0d39e26f-b641-e142-6c90-7f4bcf91fc21@suse.cz> (raw)
In-Reply-To: <544e7eaf-ceaa-0ff0-15c3-b615db7e1b00@codeaurora.org>

On 5/26/21 5:06 PM, Faiyaz Mohammed wrote:
>> How about simply replicating the empty function in
>> include/linux/slab_def.h
>> 
> Yes, we can add empty function in include/linux/slab_def.h.
> I will add in next patch version.
> 
>> We could do the same with SYSFS, except the SLAB (and SLUB w/o SYSFS) versions
>> of sysfs_slab_release() would not be empty, but just call
>> slab_kmem_cache_release(s);
>> Then we could get rid of the #ifdef's completely?
>> 
> Is it okay, if I raise separate patch for sysfs by adding empty function
> in slab_def.h?

Yeah that would be cleaner. Thanks.

> Thanks and regards,
> Mohammed Faiyaz
>>> greg k-h
>>>
>> 
> 



  reply	other threads:[~2021-05-26 15:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  7:38 [PATCH v7] mm: slub: move sysfs slab alloc/free interfaces to debugfs Faiyaz Mohammed
2021-05-25  7:53 ` Greg KH
2021-05-25  8:57   ` Faiyaz Mohammed
2021-05-25 11:54     ` Greg KH
2021-05-26 11:03       ` Vlastimil Babka
2021-05-26 15:06         ` Faiyaz Mohammed
2021-05-26 15:07           ` Vlastimil Babka [this message]
2021-05-26 11:38 ` Vlastimil Babka
2021-05-26 11:48   ` Greg KH
2021-05-26 12:13     ` Vlastimil Babka
2021-05-31  7:11       ` Faiyaz Mohammed
2021-05-31  8:19         ` Vlastimil Babka
2021-05-31  9:50           ` Faiyaz Mohammed
2021-05-31  6:55   ` Faiyaz Mohammed
2021-05-31  9:55     ` Vlastimil Babka
2021-05-31 11:07       ` Faiyaz Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d39e26f-b641-e142-6c90-7f4bcf91fc21@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=faiyazm@codeaurora.org \
    --cc=glittao@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vinmenon@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).