From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45274C2D0EC for ; Fri, 27 Mar 2020 23:32:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC2B4206E6 for ; Fri, 27 Mar 2020 23:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC2B4206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 64F796B000E; Fri, 27 Mar 2020 19:32:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FFAF6B0032; Fri, 27 Mar 2020 19:32:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53C956B0036; Fri, 27 Mar 2020 19:32:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 38DC36B000E for ; Fri, 27 Mar 2020 19:32:43 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E5FDE180AD811 for ; Fri, 27 Mar 2020 23:32:42 +0000 (UTC) X-FDA: 76642744164.03.army76_8c01bd693e328 X-HE-Tag: army76_8c01bd693e328 X-Filterd-Recvd-Size: 2512 Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Mar 2020 23:32:42 +0000 (UTC) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4DCD976769C895C2FE5A; Sat, 28 Mar 2020 07:32:38 +0800 (CST) Received: from [10.173.228.124] (10.173.228.124) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sat, 28 Mar 2020 07:32:27 +0800 Subject: Re: [PATCH v3] mm/hugetlb: fix a addressing exception caused by huge_pte_offset To: Jason Gunthorpe CC: , , , , , , , Mike Kravetz , Andrew Morton , "Matthew Wilcox" , Sean Christopherson , References: <20200327014007.1915-1-longpeng2@huawei.com> <20200327121100.GR20941@ziepe.ca> From: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" Message-ID: <0d8771ec-9661-9ef4-0972-4dadf548487b@huawei.com> Date: Sat, 28 Mar 2020 07:32:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20200327121100.GR20941@ziepe.ca> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.228.124] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/3/27 20:11, Jason Gunthorpe wrote: > On Fri, Mar 27, 2020 at 09:40:07AM +0800, Longpeng(Mike) wrote: >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index dd8737a..d4fab68 100644 >> +++ b/mm/hugetlb.c >> @@ -4909,29 +4909,33 @@ pte_t *huge_pte_offset(struct mm_struct *mm, >> unsigned long addr, unsigned long sz) >> { >> pgd_t *pgd; >> - p4d_t *p4d; >> - pud_t *pud; >> - pmd_t *pmd; >> + p4d_t *p4g, p4d_entry; >> + pud_t *pud, pud_entry; >> + pmd_t *pmd, pmd_entry; >> >> pgd = pgd_offset(mm, addr); >> if (!pgd_present(*pgd)) >> return NULL; >> - p4d = p4d_offset(pgd, addr); >> - if (!p4d_present(*p4d)) >> + >> + p4g = p4d_offset(pgd, addr); > > Why p4g here? Shouldn't it be p4d? > Sorry, it's a typo, I'll send v4 > Jason > . > --- Regards, Longpeng(Mike)