From: Mike Kravetz <mike.kravetz@oracle.com>
To: Mina Almasry <almasrymina@google.com>
Cc: shuah <shuah@kernel.org>, "David Rientjes" <rientjes@google.com>,
"Shakeel Butt" <shakeelb@google.com>,
"Greg Thelen" <gthelen@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"open list" <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
cgroups@vger.kernel.org,
"Aneesh Kumar" <aneesh.kumar@linux.vnet.ibm.com>,
"Michal Koutný" <mkoutny@suse.com>,
"Hillf Danton" <hdanton@sina.com>
Subject: Re: [PATCH v9 3/8] hugetlb_cgroup: add reservation accounting for private mappings
Date: Fri, 17 Jan 2020 14:09:42 -0800 [thread overview]
Message-ID: <0ea993b0-af18-cee8-527e-f6df7e76b0be@oracle.com> (raw)
In-Reply-To: <CAHS8izMzXpNMCmFh_SD7n+4+rj3QTqyRfeWQyXAhFo1-qV4iEQ@mail.gmail.com>
On 1/14/20 2:52 PM, Mina Almasry wrote:
> On Mon, Jan 13, 2020 at 4:55 PM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>>> +#ifdef CONFIG_CGROUP_HUGETLB
>>> + /*
>>> + * Since we check for HPAGE_RESV_OWNER above, this must a private
>>> + * mapping, and these values should be none-zero, and should point to
>>> + * the hugetlb_cgroup counter to uncharge for this reservation.
>>> + */
>>> + WARN_ON(!resv->reservation_counter);
>>> + WARN_ON(!resv->pages_per_hpage);
>>> + WARN_ON(!resv->css);
>>
>> I was once again wondering if these were always non-NULL for private mappings.
>> It seems that reservation_counter (h_gc) would be NULL in these cases from
>> these early checks in hugetlb_cgroup_charge_cgroup().
>>
>
> You are right. I'm fixing in v10 the code and comments to account for
> h_cg potentially being NULL, but I'm having trouble testing. Looking
> at the code, I'm a bit confused by the checks. Seems to me
> hugetlb_cgroup_disabled() is the same as #ifdef CONFIG_CGROUP_HUGETLB;
> I can't find a way to enable the Kconfig but have that return false
> unless I hack the code.
What about the boot options?
cgroup_disable=
cgroup_no_v1=
--
Mike Kravetz
next prev parent reply other threads:[~2020-01-17 22:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 23:16 [PATCH v9 1/8] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Mina Almasry
2019-12-17 23:16 ` [PATCH v9 2/8] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations Mina Almasry
2020-01-13 22:14 ` Mike Kravetz
2020-01-14 0:45 ` David Rientjes
2020-01-14 22:55 ` Mina Almasry
2019-12-17 23:16 ` [PATCH v9 3/8] hugetlb_cgroup: add reservation accounting for private mappings Mina Almasry
2020-01-14 0:55 ` Mike Kravetz
2020-01-14 22:52 ` Mina Almasry
2020-01-17 22:09 ` Mike Kravetz [this message]
2020-01-22 21:40 ` Mina Almasry
2019-12-17 23:16 ` [PATCH v9 4/8] hugetlb: disable region_add file_region coalescing Mina Almasry
2020-01-21 17:38 ` Mike Kravetz
2020-01-21 17:40 ` Mike Kravetz
2019-12-17 23:16 ` [PATCH v9 5/8] hugetlb_cgroup: add accounting for shared mappings Mina Almasry
2019-12-17 23:16 ` [PATCH v9 6/8] hugetlb_cgroup: support noreserve mappings Mina Almasry
2020-01-14 0:48 ` David Rientjes
2019-12-17 23:16 ` [PATCH v9 7/8] hugetlb_cgroup: Add hugetlb_cgroup reservation tests Mina Almasry
2019-12-17 23:16 ` [PATCH v9 8/8] hugetlb_cgroup: Add hugetlb_cgroup reservation docs Mina Almasry
2020-01-14 0:54 ` David Rientjes
2019-12-19 1:12 ` [PATCH v9 1/8] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Andrew Morton
2019-12-19 1:37 ` Mike Kravetz
2019-12-19 1:59 ` Mina Almasry
2020-01-13 18:43 ` Mike Kravetz
2020-01-13 21:03 ` Mina Almasry
2020-01-13 22:05 ` Mike Kravetz
2020-01-13 22:21 ` Mina Almasry
2020-01-14 0:45 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea993b0-af18-cee8-527e-f6df7e76b0be@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).