From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3C3C4361B for ; Tue, 8 Dec 2020 09:09:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0951423A7F for ; Tue, 8 Dec 2020 09:09:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0951423A7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 525196B0068; Tue, 8 Dec 2020 04:09:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FA936B006C; Tue, 8 Dec 2020 04:09:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 438466B006E; Tue, 8 Dec 2020 04:09:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 2D3C86B0068 for ; Tue, 8 Dec 2020 04:09:25 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E16FF6D9F for ; Tue, 8 Dec 2020 09:09:24 +0000 (UTC) X-FDA: 77569541448.19.bed62_3512091273e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id BB2231AD1B9 for ; Tue, 8 Dec 2020 09:09:24 +0000 (UTC) X-HE-Tag: bed62_3512091273e5 X-Filterd-Recvd-Size: 3051 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 09:09:22 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R441e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UHyyIaT_1607418552; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UHyyIaT_1607418552) by smtp.aliyun-inc.com(127.0.0.1); Tue, 08 Dec 2020 17:09:13 +0800 Subject: Re: [PATCH 10/11] mm: make lruvec_lru_size() static To: Yu Zhao , Andrew Morton , Hugh Dickins Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-11-yuzhao@google.com> From: Alex Shi Message-ID: <10396c35-9e42-b3a0-0183-490e10e6ad0c@linux.alibaba.com> Date: Tue, 8 Dec 2020 17:09:12 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201207220949.830352-11-yuzhao@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Reviewed-by: Alex Shi =E5=9C=A8 2020/12/8 =E4=B8=8A=E5=8D=886:09, Yu Zhao =E5=86=99=E9=81=93: > All other references to the function were removed after > commit b910718a948a ("mm: vmscan: detect file thrashing at the reclaim = root") >=20 > Signed-off-by: Yu Zhao > --- > include/linux/mmzone.h | 2 -- > mm/vmscan.c | 3 ++- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index b593316bff3d..2fc54e269eaf 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -872,8 +872,6 @@ static inline struct pglist_data *lruvec_pgdat(stru= ct lruvec *lruvec) > #endif > } > =20 > -extern unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_l= ist lru, int zone_idx); > - > #ifdef CONFIG_HAVE_MEMORYLESS_NODES > int local_memory_node(int node_id); > #else > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 95e581c9d9af..fd0c2313bee4 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -310,7 +310,8 @@ unsigned long zone_reclaimable_pages(struct zone *z= one) > * @lru: lru to use > * @zone_idx: zones to consider (use MAX_NR_ZONES for the whole LRU li= st) > */ > -unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru= , int zone_idx) > +static unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_l= ist lru, > + int zone_idx) > { > unsigned long size =3D 0; > int zid; >=20