From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D103C4338F for ; Mon, 2 Aug 2021 12:02:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2706460FC2 for ; Mon, 2 Aug 2021 12:02:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2706460FC2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5B46B8D0002; Mon, 2 Aug 2021 08:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 563BB8D0001; Mon, 2 Aug 2021 08:02:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 452978D0002; Mon, 2 Aug 2021 08:02:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 29DE48D0001 for ; Mon, 2 Aug 2021 08:02:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AE1611F352 for ; Mon, 2 Aug 2021 12:02:16 +0000 (UTC) X-FDA: 78430002672.01.4D9889D Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by imf03.hostedemail.com (Postfix) with ESMTP id 27DAC300E549 for ; Mon, 2 Aug 2021 12:01:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1627905676; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=2TAtXvlUUR0mBh67yB7f449WY+htKivr3VQmX7vMj9Y=; b=H2mYdUe1tiMq/VQ+cbKA9dG+zQ6Jdv4JLz33ekpnQXDXFT55AzYaa/aJ/EmGCoRXc5q2lRxk Z60lLiLSAVhDwe/TucCDYEodAT+YcjEwFhFg6WNFEYG87iWKIOTmRJAOwzOxe3pDk8OQW7rD 42YmvXKg4zahZsd+uXKB3pXADGU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 6107de5a17c2b4047d859af7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 02 Aug 2021 12:00:26 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7EE91C433F1; Mon, 2 Aug 2021 12:00:25 +0000 (UTC) Received: from [192.168.29.110] (unknown [49.37.157.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: charante) by smtp.codeaurora.org (Postfix) with ESMTPSA id E568FC43460; Mon, 2 Aug 2021 12:00:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E568FC43460 Subject: Re: [PATCH V5] mm: compaction: support triggering of proactive compaction by user To: Mike Rapoport Cc: akpm@linux-foundation.org, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, dave.hansen@linux.intel.com, vbabka@suse.cz, mgorman@techsingularity.net, nigupta@nvidia.com, corbet@lwn.net, khalid.aziz@oracle.com, rientjes@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, vinmenon@codeaurora.org References: <1627653207-12317-1-git-send-email-charante@codeaurora.org> From: Charan Teja Kalla Message-ID: <1089d373-221e-7094-b778-ac260ca139a5@codeaurora.org> Date: Mon, 2 Aug 2021 17:30:16 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 27DAC300E549 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=mg.codeaurora.org header.s=smtp header.b=H2mYdUe1; dmarc=none; spf=pass (imf03.hostedemail.com: domain of bounce@mg.codeaurora.org designates 69.72.43.7 as permitted sender) smtp.mailfrom=bounce@mg.codeaurora.org X-Stat-Signature: z3yjs4xzcfafiztbckdzqijdiqtumb73 X-HE-Tag: 1627905670-988407 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks Mike for the review!! On 7/31/2021 1:01 AM, Mike Rapoport wrote: >> diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst >> index 003d5cc..b526cf6 100644 >> --- a/Documentation/admin-guide/sysctl/vm.rst >> +++ b/Documentation/admin-guide/sysctl/vm.rst >> @@ -118,7 +118,8 @@ compaction_proactiveness >> >> This tunable takes a value in the range [0, 100] with a default value of >> 20. This tunable determines how aggressively compaction is done in the >> -background. Setting it to 0 disables proactive compaction. >> +background. On write of non zero value to this tunable will immediately > Nit: I think "Write of non zero ..." Can Andrew change it while applying the patch ? > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project