From: Ian Kent <raven@themaw.net>
To: Randy Dunlap <rdunlap@infradead.org>,
akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: mmotm 2018-05-17-16-26 uploaded (autofs)
Date: Mon, 21 May 2018 08:49:08 +0800 [thread overview]
Message-ID: <11712bc6-9d45-7bb1-4e88-720ee3e312dd@themaw.net> (raw)
In-Reply-To: <d225202d-fcba-851d-63a6-ae6a1c3ae0e7@themaw.net>
On 21/05/18 08:43, Ian Kent wrote:
>>>
>>> It looks like adding:
>>> depends on AUTOFS_FS = n && AUTOFS_FS != m
>>
>> Hi. Is there a typo on the line above?
LOL, but your point is what does the AUTOFS_FS != m do!
The answer should be nothing but ..... I'll have to play
a little more.
>
> Don't think so.
>
> This was straight out of:
>
> diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig
> index 53bc592a250d..2f9bafabac1b 100644
> --- a/fs/autofs4/Kconfig
> +++ b/fs/autofs4/Kconfig
> @@ -1,6 +1,7 @@
> config AUTOFS4_FS
> tristate "Kernel automounter version 4 support (also supports v3 and v5)"
> default n
> + depends on AUTOFS_FS = n && AUTOFS_FS != m
> help
> The automounter is a tool to automatically mount remote file systems
> on demand. This implementation is partially kernel-based to reduce
> @@ -30,3 +31,10 @@ config AUTOFS4_FS
> - any "alias autofs autofs4" will need to be removed.
>
> Please configure AUTOFS_FS instead of AUTOFS4_FS from now on.
> +
> + NOTE: Since the modules autofs and autofs4 use the same file system
> + type name of "autofs" only one can be built. The "depends"
> + above will result in AUTOFS4_FS not appearing in .config for
> + any setting of AUTOFS_FS other than n and AUTOFS4_FS will
> + appear under the AUTOFS_FS entry otherwise which is intended
> + to draw attention to the module rename change.
>
> which appears to do what's needed about as well as can be done and deals
> with the AUTOFS4_FS=y && AUTOFS_FS=y case.
>
> Ian
>
prev parent reply other threads:[~2018-05-21 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 23:26 mmotm 2018-05-17-16-26 uploaded akpm
2018-05-18 0:21 ` mmotm 2018-05-17-16-26 uploaded (autofs) Randy Dunlap
2018-05-18 3:50 ` Ian Kent
2018-05-18 4:23 ` Randy Dunlap
2018-05-18 4:38 ` Ian Kent
2018-05-18 6:09 ` Ian Kent
2018-05-18 16:22 ` Randy Dunlap
2018-05-21 0:43 ` Ian Kent
2018-05-21 0:49 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11712bc6-9d45-7bb1-4e88-720ee3e312dd@themaw.net \
--to=raven@themaw.net \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).