From: Alistair Popple <apopple@nvidia.com>
To: Peter Xu <peterx@redhat.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Axel Rasmussen <axelrasmussen@google.com>,
Nadav Amit <nadav.amit@gmail.com>,
Hugh Dickins <hughd@google.com>,
Jerome Glisse <jglisse@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Matthew Wilcox <willy@infradead.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH v3 08/27] mm: Introduce zap_details.zap_flags
Date: Tue, 22 Jun 2021 12:07:53 +1000 [thread overview]
Message-ID: <12693036.q1u8oJ8qPt@nvdebian> (raw)
In-Reply-To: <YNC7csnnSWXz6xvJ@t490s>
On Tuesday, 22 June 2021 2:16:50 AM AEST Peter Xu wrote:
> On Mon, Jun 21, 2021 at 10:09:00PM +1000, Alistair Popple wrote:
> > On Friday, 28 May 2021 6:21:30 AM AEST Peter Xu wrote:
> > > Instead of trying to introduce one variable for every new zap_details fields,
> > > let's introduce a flag so that it can start to encode true/false informations.
> > >
> > > Let's start to use this flag first to clean up the only check_mapping variable.
> > > Firstly, the name "check_mapping" implies this is a "boolean", but actually it
> > > stores the mapping inside, just in a way that it won't be set if we don't want
> > > to check the mapping.
> > >
> > > To make things clearer, introduce the 1st zap flag ZAP_FLAG_CHECK_MAPPING, so
> > > that we only check against the mapping if this bit set. At the same time, we
> > > can rename check_mapping into zap_mapping and set it always.
> > >
> > > Since at it, introduce another helper zap_check_mapping_skip() and use it in
> > > zap_pte_range() properly.
> > >
> > > Some old comments have been removed in zap_pte_range() because they're
> > > duplicated, and since now we're with ZAP_FLAG_CHECK_MAPPING flag, it'll be very
> > > easy to grep this information by simply grepping the flag.
> > >
> > > It'll also make life easier when we want to e.g. pass in zap_flags into the
> > > callers like unmap_mapping_pages() (instead of adding new booleans besides the
> > > even_cows parameter).
> > >
> > > Signed-off-by: Peter Xu <peterx@redhat.com>
> > > ---
> > > include/linux/mm.h | 19 ++++++++++++++++++-
> > > mm/memory.c | 31 ++++++++-----------------------
> > > 2 files changed, 26 insertions(+), 24 deletions(-)
> > >
> > > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > > index db155be8e66c..52d3ef2ed753 100644
> > > --- a/include/linux/mm.h
> > > +++ b/include/linux/mm.h
> > > @@ -1721,13 +1721,30 @@ static inline bool can_do_mlock(void) { return false; }
> > > extern int user_shm_lock(size_t, struct user_struct *);
> > > extern void user_shm_unlock(size_t, struct user_struct *);
> > >
> > > +/* Whether to check page->mapping when zapping */
> > > +#define ZAP_FLAG_CHECK_MAPPING BIT(0)
> > > +
> > > /*
> > > * Parameter block passed down to zap_pte_range in exceptional cases.
> > > */
> > > struct zap_details {
> > > - struct address_space *check_mapping; /* Check page->mapping if set */
> > > + struct address_space *zap_mapping;
> > > + unsigned long zap_flags;
> > > };
> > >
> > > +/* Return true if skip zapping this page, false otherwise */
> > > +static inline bool
> > > +zap_check_mapping_skip(struct zap_details *details, struct page *page)
> > > +{
> > > + if (!details || !page)
> > > + return false;
> > > +
> > > + if (!(details->zap_flags & ZAP_FLAG_CHECK_MAPPING))
> > > + return false;
>
> [1]
>
> > > +
> > > + return details->zap_mapping != page_rmapping(page);
> >
> > I doubt this matters in practice, but there is a slight behaviour change
> > here that might be worth checking. Previously this check was equivalent
> > to:
> >
> > details->zap_mapping && details->zap_mapping != page_rmapping(page)
>
> Yes; IMHO "details->zap_mapping" is just replaced by the check at [1].
Yes, but what I meant is that this check is slightly different in behaviour
from the old code which would never skip if check/zap_mapping == NULL where as
the new code will skip if
details->zap_mapping == NULL && page_rmapping(page) != NULL because the check
has effectively become:
if ((details->zap_flags & ZAP_FLAG_CHECK_MAPPING) &&
details->zap_mapping != page_rmapping(page))
continue;
instead of:
if (details->zap_mapping &&
details->zap_mapping != page_rmapping(page))
continue;
As I said though I only looked at this superficially from the perspective of
whether this patch changes existing code behaviour. I doubt this is a real
problem because I assume
details->check_mapping == NULL && page_rmapping(page) != NULL can never
actually happen in practice.
> For example, there's only one real user of this mapping check, which is
> unmap_mapping_pages() below [2].
>
> With the old code, we have:
>
> details.check_mapping = even_cows ? NULL : mapping;
>
> So "details->zap_mapping" is only true if "!even_cows".
>
> With the new code, we'll have:
>
> if (!even_cows)
> details.zap_flags |= ZAP_FLAG_CHECK_MAPPING;
>
> So ZAP_FLAG_CHECK_MAPPING is only set if "!even_cows", while that's what we
> check exactly at [1].
> >
> > Otherwise I think this looks good.
> >
> > > +}
> > > +
> > > struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
> > > pte_t pte);
> > > struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr,
> > > diff --git a/mm/memory.c b/mm/memory.c
> > > index 27cf8a6375c6..c9dc4e9e05b5 100644
> > > --- a/mm/memory.c
> > > +++ b/mm/memory.c
> > > @@ -1330,16 +1330,8 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> > > struct page *page;
> > >
> > > page = vm_normal_page(vma, addr, ptent);
> > > - if (unlikely(details) && page) {
> > > - /*
> > > - * unmap_shared_mapping_pages() wants to
> > > - * invalidate cache without truncating:
> > > - * unmap shared but keep private pages.
> > > - */
> > > - if (details->check_mapping &&
> > > - details->check_mapping != page_rmapping(page))
> > > - continue;
> > > - }
> > > + if (unlikely(zap_check_mapping_skip(details, page)))
> > > + continue;
> > > ptent = ptep_get_and_clear_full(mm, addr, pte,
> > > tlb->fullmm);
> > > tlb_remove_tlb_entry(tlb, pte, addr);
> > > @@ -1372,17 +1364,8 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> > > is_device_exclusive_entry(entry)) {
> > > struct page *page = pfn_swap_entry_to_page(entry);
> > >
> > > - if (unlikely(details && details->check_mapping)) {
> > > - /*
> > > - * unmap_shared_mapping_pages() wants to
> > > - * invalidate cache without truncating:
> > > - * unmap shared but keep private pages.
> > > - */
> > > - if (details->check_mapping !=
> > > - page_rmapping(page))
> > > - continue;
> > > - }
> > > -
> > > + if (unlikely(zap_check_mapping_skip(details, page)))
> > > + continue;
> > > pte_clear_not_present_full(mm, addr, pte, tlb->fullmm);
> > > rss[mm_counter(page)]--;
> > >
> > > @@ -3345,9 +3328,11 @@ void unmap_mapping_pages(struct address_space *mapping, pgoff_t start,
> > > pgoff_t nr, bool even_cows)
> > > {
> > > pgoff_t first_index = start, last_index = start + nr - 1;
> > > - struct zap_details details = { };
> > > + struct zap_details details = { .zap_mapping = mapping };
> > > +
> > > + if (!even_cows)
> > > + details.zap_flags |= ZAP_FLAG_CHECK_MAPPING;
> > >
> > > - details.check_mapping = even_cows ? NULL : mapping;
>
> [2]
>
> > > if (last_index < first_index)
> > > last_index = ULONG_MAX;
>
> Thanks,
>
>
next prev parent reply other threads:[~2021-06-22 2:08 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 20:19 [PATCH v3 00/27] userfaultfd-wp: Support shmem and hugetlbfs Peter Xu
2021-05-27 20:19 ` [PATCH v3 01/27] mm/shmem: Unconditionally set pte dirty in mfill_atomic_install_pte Peter Xu
2021-05-27 20:19 ` [PATCH v3 02/27] shmem/userfaultfd: Take care of UFFDIO_COPY_MODE_WP Peter Xu
2021-05-27 20:19 ` [PATCH v3 03/27] mm: Clear vmf->pte after pte_unmap_same() returns Peter Xu
2021-05-27 20:19 ` [PATCH v3 04/27] mm/userfaultfd: Introduce special pte for unmapped file-backed mem Peter Xu
2021-05-28 8:32 ` Alistair Popple
2021-05-28 12:56 ` Peter Xu
2021-06-03 11:53 ` Alistair Popple
2021-06-03 14:51 ` Peter Xu
2021-06-04 0:55 ` Alistair Popple
2021-06-04 3:14 ` Hugh Dickins
2021-06-04 6:16 ` Alistair Popple
2021-06-04 16:01 ` Peter Xu
2021-06-08 13:18 ` Alistair Popple
2021-06-09 13:06 ` Alistair Popple
2021-06-09 14:43 ` Peter Xu
2021-05-27 20:21 ` [PATCH v3 05/27] mm/swap: Introduce the idea of special swap ptes Peter Xu
2021-05-27 20:21 ` [PATCH v3 06/27] shmem/userfaultfd: Handle uffd-wp special pte in page fault handler Peter Xu
2021-06-17 8:59 ` Alistair Popple
2021-06-17 15:10 ` Peter Xu
2021-05-27 20:21 ` [PATCH v3 07/27] mm: Drop first_index/last_index in zap_details Peter Xu
2021-06-21 12:20 ` Alistair Popple
2021-05-27 20:21 ` [PATCH v3 08/27] mm: Introduce zap_details.zap_flags Peter Xu
2021-06-21 12:09 ` Alistair Popple
2021-06-21 16:16 ` Peter Xu
2021-06-22 2:07 ` Alistair Popple [this message]
2021-05-27 20:21 ` [PATCH v3 09/27] mm: Introduce ZAP_FLAG_SKIP_SWAP Peter Xu
2021-06-21 12:36 ` Alistair Popple
2021-06-21 16:26 ` Peter Xu
2021-06-22 2:11 ` Alistair Popple
2021-05-27 20:21 ` [PATCH v3 10/27] mm: Pass zap_flags into unmap_mapping_pages() Peter Xu
2021-05-27 20:22 ` [PATCH v3 11/27] shmem/userfaultfd: Persist uffd-wp bit across zapping for file-backed Peter Xu
2021-06-21 8:41 ` Alistair Popple
2021-06-22 0:40 ` Peter Xu
2021-06-22 12:47 ` Alistair Popple
2021-06-22 15:44 ` Peter Xu
2021-06-23 6:04 ` Alistair Popple
2021-06-23 15:31 ` Peter Xu
2021-07-06 5:40 ` Alistair Popple
2021-07-06 15:35 ` Peter Xu
2021-07-08 2:49 ` Alistair Popple
2021-05-27 20:22 ` [PATCH v3 12/27] shmem/userfaultfd: Allow wr-protect none pte for file-backed mem Peter Xu
2021-05-27 20:22 ` [PATCH v3 13/27] shmem/userfaultfd: Allows file-back mem to be uffd wr-protected on thps Peter Xu
2021-05-27 20:22 ` [PATCH v3 14/27] shmem/userfaultfd: Handle the left-overed special swap ptes Peter Xu
2021-05-27 20:22 ` [PATCH v3 15/27] shmem/userfaultfd: Pass over uffd-wp special swap pte when fork() Peter Xu
2021-05-27 20:23 ` [PATCH v3 16/27] mm/hugetlb: Drop __unmap_hugepage_range definition from hugetlb.h Peter Xu
2021-05-27 20:23 ` [PATCH v3 17/27] mm/hugetlb: Introduce huge pte version of uffd-wp helpers Peter Xu
2021-05-27 20:23 ` [PATCH v3 18/27] hugetlb/userfaultfd: Hook page faults for uffd write protection Peter Xu
2021-05-27 20:23 ` [PATCH v3 19/27] hugetlb/userfaultfd: Take care of UFFDIO_COPY_MODE_WP Peter Xu
2021-05-27 20:23 ` [PATCH v3 20/27] hugetlb/userfaultfd: Handle UFFDIO_WRITEPROTECT Peter Xu
2021-05-27 20:23 ` [PATCH v3 21/27] mm/hugetlb: Introduce huge version of special swap pte helpers Peter Xu
2021-05-27 20:23 ` [PATCH v3 22/27] hugetlb/userfaultfd: Handle uffd-wp special pte in hugetlb pf handler Peter Xu
2021-05-27 20:23 ` [PATCH v3 23/27] hugetlb/userfaultfd: Allow wr-protect none ptes Peter Xu
2021-05-27 20:23 ` [PATCH v3 24/27] hugetlb/userfaultfd: Only drop uffd-wp special pte if required Peter Xu
2021-05-27 20:23 ` [PATCH v3 25/27] mm/pagemap: Recognize uffd-wp bit for shmem/hugetlbfs Peter Xu
2021-05-27 20:23 ` [PATCH v3 26/27] mm/userfaultfd: Enable write protection for shmem & hugetlbfs Peter Xu
2021-05-27 20:23 ` [PATCH v3 27/27] userfaultfd/selftests: Enable uffd-wp for shmem/hugetlbfs Peter Xu
2021-06-02 14:40 ` [PATCH v3 00/27] userfaultfd-wp: Support shmem and hugetlbfs Peter Xu
2021-06-02 22:36 ` Andrew Morton
2021-06-03 0:09 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12693036.q1u8oJ8qPt@nvdebian \
--to=apopple@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nadav.amit@gmail.com \
--cc=peterx@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).