From: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, Kirill Tkhai <ktkhai@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, vdavydov.dev@gmail.com,
mhocko@suse.com, aryabinin@virtuozzo.com, ying.huang@intel.com,
penguin-kernel@I-love.SAKURA.ne.jp, willy@infradead.org,
shakeelb@google.com, jbacik@fb.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Move check for SHRINKER_NUMA_AWARE to do_shrink_slab()
Date: Fri, 03 Aug 2018 12:18:45 +0100 [thread overview]
Message-ID: <12714.1533295125@warthog.procyon.org.uk> (raw)
In-Reply-To: <8347.1533292272@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> But! I'm not sure why the reproducer works at all because the umount2() call
> is *after* the chroot, so should fail on ENOENT before it even gets that
> far.
No, it shouldn't. It did chroot() not chdir().
> In fact, umount2() can be called multiple times, apparently successfully, and
> doesn't actually unmount anything.
Okay, because it chroot'd into the directory. Should it return EBUSY though?
David
prev parent reply other threads:[~2018-08-03 11:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:00 [PATCH] mm: Move check for SHRINKER_NUMA_AWARE to do_shrink_slab() Kirill Tkhai
2018-08-02 16:47 ` Yang Shi
2018-08-02 16:54 ` Shakeel Butt
2018-08-02 17:26 ` Yang Shi
2018-08-03 7:11 ` Kirill Tkhai
2018-08-02 20:47 ` Andrew Morton
2018-08-03 9:02 ` Kirill Tkhai
2018-08-03 10:31 ` David Howells
2018-08-03 10:59 ` Kirill Tkhai
2018-08-03 11:04 ` Kirill Tkhai
2018-08-03 12:00 ` David Howells
2018-08-03 11:18 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12714.1533295125@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=jbacik@fb.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).